linux-kernel - Re: [PATCH] drm/panel: ili9341: Remove a superfluous else after return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86b768d8-19e8-4f87-a250-b428bf78f756@quicinc.com>
Date: Mon, 29 Apr 2024 16:10:26 -0700
From: Jessica Zhang <quic_jesszhan@...cinc.com>
To: Sui Jingfeng <sui.jingfeng@...ux.dev>,
        Neil Armstrong
	<neil.armstrong@...aro.org>
CC: Sam Ravnborg <sam@...nborg.org>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/panel: ili9341: Remove a superfluous else after
 return



On 4/29/2024 10:12 AM, Sui Jingfeng wrote:
> The else clause after the ruturn clause is not useful.

Hi Sui,

Spelling nit: ruturn --> return

Besides that,

Reviewed-by: Jessica Zhang <quic_jesszhan@...cinc.com>

Thanks,

Jessica Zhang

> 
> Signed-off-by: Sui Jingfeng <sui.jingfeng@...ux.dev>
> ---
>   drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> index 3574681891e8..433572c4caf9 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> @@ -722,7 +722,8 @@ static int ili9341_probe(struct spi_device *spi)
>   
>   	if (!strcmp(id->name, "sf-tc240t-9370-t"))
>   		return ili9341_dpi_probe(spi, dc, reset);
> -	else if (!strcmp(id->name, "yx240qv29"))
> +
> +	if (!strcmp(id->name, "yx240qv29"))
>   		return ili9341_dbi_probe(spi, dc, reset);
>   
>   	return -1;
> -- 
> 2.34.1
>