linux-kernel - Re: [PATCH] serial: sc16is7xx: fix bug in sc16is7xx_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17d2cc58-cf68-430d-9248-25abe4c5b0f0@kernel.org>
Date: Mon, 29 Apr 2024 08:39:22 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Hugo Villeneuve <hugo@...ovil.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jon Ringle <jringle@...dpoint.com>
Cc: ria.freelander@...il.com, Hugo Villeneuve <hvilleneuve@...onoff.com>,
 stable@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: sc16is7xx: fix bug in sc16is7xx_set_baud() when
 using prescaler

On 26. 04. 24, 15:59, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> 
> When using a high speed clock with a low baud rate, the 4x prescaler is
> automatically selected if required. In that case, sc16is7xx_set_baud()
> properly configures the chip registers, but returns an incorrect baud
> rate by not taking into account the prescaler value. This incorrect baud
> rate is then fed to uart_update_timeout().
> 
> For example, with an input clock of 80MHz, and a selected baud rate of 50,
> sc16is7xx_set_baud() will return 200 instead of 50.
> 
> Fix this by first changing the prescaler variable to hold the selected
> prescaler value instead of the MCR bitfield. Then properly take into
> account the selected prescaler value in the return value computation.
> 
> Also add better documentation about the divisor value computation.
> 
> Fixes: dfeae619d781 ("serial: sc16is7xx")
> Cc: stable@...r.kernel.org
> Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> ---
>   drivers/tty/serial/sc16is7xx.c | 23 ++++++++++++++++++-----
>   1 file changed, 18 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 03cf30e20b75..dcd6c5615401 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -555,16 +555,28 @@ static bool sc16is7xx_regmap_noinc(struct device *dev, unsigned int reg)
>   	return reg == SC16IS7XX_RHR_REG;
>   }
>   
> +/*
> + * Configure programmable baud rate generator (divisor) according to the
> + * desired baud rate.
> + *
> + * From the datasheet, the divisor is computed according to:
> + *
> + *              XTAL1 input frequency
> + *             -----------------------
> + *                    prescaler
> + * divisor = ---------------------------
> + *            baud-rate x sampling-rate
> + */
>   static int sc16is7xx_set_baud(struct uart_port *port, int baud)
>   {
>   	struct sc16is7xx_one *one = to_sc16is7xx_one(port, port);
>   	u8 lcr;
> -	u8 prescaler = 0;
> +	int prescaler = 1;

Ugh, why do you move to signed arithmetics?

regards,
-- 
js
suse labs