linux-kernel - Re: [RFC PATCH] spi: dt-bindings: ti,qspi: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Apr 2024 09:25:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kousik Sanagavarapu <five231003@...il.com>
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-spi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>
Subject: Re: [RFC PATCH] spi: dt-bindings: ti,qspi: convert to dtschema

On 29/04/2024 09:10, Kousik Sanagavarapu wrote:
> On Mon, Apr 29, 2024 at 07:07:38AM +0200, Krzysztof Kozlowski wrote:
>> On 28/04/2024 08:58, Kousik Sanagavarapu wrote:
>>> Convert txt binding of TI's qspi controller (found on their omap SoCs) to
>>> dtschema to allow for validation.
> 
> [...]
> 
>>> +  spi-max-frequency:
>>> +    description: Maximum SPI clocking speed of the controller in Hz.
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>
>>
>> Are you sure that's actually needed? That's not a property of controller.
> 
> [...]
> 
>>> +        num-cs = <4>;
>>> +        spi-max-frequency = <48000000>;
>>
>> Drop. Are you sure driver parses it?
> 
> The driver does parse it though.  Looking at
> drivers/spi/spi-ti-qspi.c::ti_qspi_probe(),
> 
> 	if (!of_property_read_u32(np, "spi-max-frequency", &max_freq))
> 		host->max_speed_hz = max_freq;
> 
> So I included it in the dtschema as well.  Please let me know if
> including it in the dtschema in this case is wrong.

Ah, indeed. It is fine there. Keep it in the binidng and in the example.

Best regards,
Krzysztof