linux-kernel - Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Apr 2024 10:16:01 +0200
From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
  Conor Dooley <conor+dt@...nel.org>, Yoshinori Sato
 <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>, 
 devicetree@...r.kernel.org, linux-sh@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Cc: Kousik Sanagavarapu <five231003@...il.com>
Subject: Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency
 property

On Fri, 2024-03-22 at 07:42 +0100, Krzysztof Kozlowski wrote:
> The J2 SPI controller bindings never allowed spi-max-frequency property
> in the controller node.  Neither old spi-bus.txt bindings, nor new DT
> schema allows it.  Linux driver does not parse that property from
> controller node, thus drop it from DTS as incorrect hardware
> description.  The SPI child device has already the same property with
> the same value, so functionality should not be affected.
> 
> Cc: Kousik Sanagavarapu <five231003@...il.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  arch/sh/boot/dts/j2_mimas_v2.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/sh/boot/dts/j2_mimas_v2.dts b/arch/sh/boot/dts/j2_mimas_v2.dts
> index fa9562f78d53..faf884f53804 100644
> --- a/arch/sh/boot/dts/j2_mimas_v2.dts
> +++ b/arch/sh/boot/dts/j2_mimas_v2.dts
> @@ -71,8 +71,6 @@ spi0: spi@40 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  
> -			spi-max-frequency = <25000000>;
> -
>  			reg = <0x40 0x8>;
>  
>  			sdcard@0 {

It seems that spi-bus.txt has been replaced by spi-controller.yaml now, so
I think we should update the filename in the commit message, shouldn't we?

Besides that, I agree with the changes.

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913