linux-kernel - Re: [PATCH 2/2] cxl/region: Fix missing put_device(region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ea9506e-4be7-48a2-bcc8-4ae543a7f1b5@fujitsu.com>
Date: Mon, 29 Apr 2024 08:26:19 +0000
From: "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
To: Markus Elfring <Markus.Elfring@....de>, "linux-cxl@...r.kernel.org"
	<linux-cxl@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>, Alison Schofield
	<alison.schofield@...el.com>, Dan Williams <dan.j.williams@...el.com>, Dave
 Jiang <dave.jiang@...el.com>, Davidlohr Bueso <dave@...olabs.net>, Ira Weiny
	<ira.weiny@...el.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, Vishal
 Verma <vishal.l.verma@...el.com>
CC: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] cxl/region: Fix missing put_device(region_dev)



On 29/04/2024 16:00, Markus Elfring wrote:
> …
>> Simply put_device(region_dev) if region_dev is valid in the error path.
> 
> Please improve the change description with a corresponding imperative wording.

Yeah, I always overlook this point. thank you.

Thanks
Zhijian


> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94
> 
> Regards,
> Markus