linux-kernel - Re: [PATCH v2 1/1] mmc: sdhci-of-dwcmshc: add callback functions for dwcmshc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB282270D8DBF5F2B329221C6CFE1B2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Mon, 29 Apr 2024 16:31:44 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Drew Fustini <dfustini@...storrent.com>, Chen Wang <unicornxw@...il.com>
Cc: adrian.hunter@...el.com, ulf.hansson@...aro.org,
 linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, jszhang@...nel.org,
 dfustini@...libre.com, yifeng.zhao@...k-chips.com, shawn.lin@...k-chips.com,
 chao.wei@...hgo.com, haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com,
 tingzhu.wang@...hgo.com, guoren@...nel.org, inochiama@...look.com
Subject: Re: [PATCH v2 1/1] mmc: sdhci-of-dwcmshc: add callback functions for
 dwcmshc_priv

Thank you Drew.

FYI, as per some inputs from Adrian, I will try to imrove the code and 
send a new patch.

On 2024/4/29 9:40, Drew Fustini wrote:
> On Sun, Apr 28, 2024 at 10:32:41AM +0800, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@...look.com>
>>
>> The current framework is not easily extended to support new SOCs.
>> For example, in the current code we see that the SOC-level
>> structure `rk35xx_priv` and related logic are distributed in
>> functions such as dwcmshc_probe/dwcmshc_remove/dwcmshc_suspend/......,
>> which is inappropriate.
>>
>> The solution is to abstract some possible common operations of soc
>> into virtual members of `dwcmshc_priv`. Each soc implements its own
>> corresponding callback function and registers it in init function.
>> dwcmshc framework is responsible for calling these callback functions
>> in those dwcmshc_xxx functions.
>>
>> Signed-off-by: Chen Wang <unicorn_wang@...look.com>
> I have tested this with the eMMC and microSD on the Lichee Pi 4a which
> has the T-Head TH1520 SoC.
>
> Tested-by: Drew Fustini <dfustini@...storrent.com> # TH1520
>
> Thanks,
> Drew