linux-kernel - Re: [PATCH v1] ALSA: ASoc/tas2781: fixed wrong loading calibrated data sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zi9hrs3G3i4dNtro@smile.fi.intel.com>
Date: Mon, 29 Apr 2024 12:00:30 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Shenghao Ding <shenghao-ding@...com>
Cc: broonie@...nel.org, lgirdwood@...il.com, perex@...ex.cz,
	pierre-louis.bossart@...ux.intel.com, 13916275206@....com,
	mimperial@...ovo.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, liam.r.girdwood@...el.com,
	bard.liao@...el.com, yung-chuan.liao@...ux.intel.com,
	kevin-lu@...com, cameron.berkenpas@...il.com, tiwai@...e.de,
	baojun.xu@...com, soyer@....hu, Baojun.Xu@....com
Subject: Re: [PATCH v1] ALSA: ASoc/tas2781: fixed wrong loading calibrated
 data sequence

On Sat, Apr 27, 2024 at 01:28:57PM +0800, Shenghao Ding wrote:

In the Subject:  fixed --> Fix

> Calibrated data will be set to default after loading dsp config params,

DSP

> which will cause speaker protection work abnormally. Reload calibrated
> data after loading dsp config params.

DSP

..

> -// Copyright (C) 2022 - 2023 Texas Instruments Incorporated
> +// Copyright (C) 2022 - 2024 Texas Instruments Incorporated

> -// Copyright 2023 Texas Instruments, Inc.
> +// Copyright 2023 - 2024 Texas Instruments, Inc.

Seems unrelated changes, but harmless.

..

> +						load_calib_data(tas_priv,
> +							&(cal->dev_data));

Why do you need parentheses for & (dereference) operator?

-- 
With Best Regards,
Andy Shevchenko