linux-kernel - Re: [PATCH v5 5/8] net: Remove ctl_table sentinel elements from several networking subsystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Apr 2024 11:10:05 +0200
From: Joel Granados <j.granados@...sung.com>
To: Sabrina Dubroca <sd@...asysnail.net>
CC: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@...nel.org>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexander
	Aring <alex.aring@...il.com>, Stefan Schmidt <stefan@...enfreihafen.org>,
	Miquel Raynal <miquel.raynal@...tlin.com>, David Ahern <dsahern@...nel.org>,
	Steffen Klassert <steffen.klassert@...unet.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, Matthieu Baerts <matttbe@...nel.org>, Mat
	Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>, Remi
	Denis-Courmont <courmisch@...il.com>, Allison Henderson
	<allison.henderson@...cle.com>, David Howells <dhowells@...hat.com>, Marc
	Dionne <marc.dionne@...istor.com>, Marcelo Ricardo Leitner
	<marcelo.leitner@...il.com>, Xin Long <lucien.xin@...il.com>, Wenjia Zhang
	<wenjia@...ux.ibm.com>, Jan Karcher <jaka@...ux.ibm.com>, "D. Wythe"
	<alibuda@...ux.alibaba.com>, Tony Lu <tonylu@...ux.alibaba.com>, Wen Gu
	<guwen@...ux.alibaba.com>, Trond Myklebust
	<trond.myklebust@...merspace.com>, Anna Schumaker <anna@...nel.org>, Chuck
	Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>, Neil Brown
	<neilb@...e.de>, Olga Kornievskaia <kolga@...app.com>, Dai Ngo
	<Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>, Jon Maloy
	<jmaloy@...hat.com>, Ying Xue <ying.xue@...driver.com>, Martin Schiller
	<ms@....tdt.de>, Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik
	<kadlec@...filter.org>, Florian Westphal <fw@...len.de>, Roopa Prabhu
	<roopa@...dia.com>, Nikolay Aleksandrov <razor@...ckwall.org>, Simon Horman
	<horms@...ge.net.au>, Julian Anastasov <ja@....bg>, Joerg Reuter
	<jreuter@...na.de>, Luis Chamberlain <mcgrof@...nel.org>, Kees Cook
	<keescook@...omium.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <dccp@...r.kernel.org>,
	<linux-wpan@...r.kernel.org>, <mptcp@...ts.linux.dev>,
	<linux-hams@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<rds-devel@....oracle.com>, <linux-afs@...ts.infradead.org>,
	<linux-sctp@...r.kernel.org>, <linux-s390@...r.kernel.org>,
	<linux-nfs@...r.kernel.org>, <tipc-discussion@...ts.sourceforge.net>,
	<linux-x25@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
	<coreteam@...filter.org>, <bridge@...ts.linux.dev>,
	<lvs-devel@...r.kernel.org>
Subject: Re: [PATCH v5 5/8] net: Remove ctl_table sentinel elements from
 several networking subsystems

On Fri, Apr 26, 2024 at 05:13:37PM +0200, Sabrina Dubroca wrote:
> 2024-04-26, 12:46:57 +0200, Joel Granados via B4 Relay wrote:
> > diff --git a/net/smc/smc_sysctl.c b/net/smc/smc_sysctl.c
> > index a5946d1b9d60..bd0b7e2f8824 100644
> > --- a/net/smc/smc_sysctl.c
> > +++ b/net/smc/smc_sysctl.c
> > @@ -90,7 +90,6 @@ static struct ctl_table smc_table[] = {
> >  		.extra1		= &conns_per_lgr_min,
> >  		.extra2		= &conns_per_lgr_max,
> >  	},
> > -	{  }
> >  };
> 
> There's an ARRAY_SIZE(smc_table) - 1 in smc_sysctl_net_init, shouldn't
> the -1 be removed like you did in other patches?
> 
> 
> int __net_init smc_sysctl_net_init(struct net *net)
> {
> 	struct ctl_table *table;
> 
> 	table = smc_table;
> 	if (!net_eq(net, &init_net)) {
> 		int i;
> 
> 		table = kmemdup(table, sizeof(smc_table), GFP_KERNEL);
> 		if (!table)
> 			goto err_alloc;
> 
> 		for (i = 0; i < ARRAY_SIZE(smc_table) - 1; i++)
This is a very good catch !!!! Thx a lot!! I'll put this into my V6.

> 			table[i].data += (void *)net - (void *)&init_net;
> 	}
> 
> 	net->smc.smc_hdr = register_net_sysctl_sz(net, "net/smc", table,
> 						  ARRAY_SIZE(smc_table));
> [...]
> 
> -- 
> Sabrina
> 

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)