linux-kernel - Re: [PATCH v2 0/8] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jzkg4jb3.fsf@intel.com>
Date: Mon, 29 Apr 2024 12:20:00 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Douglas Anderson <dianders@...omium.org>, dri-devel@...ts.freedesktop.org
Cc: Linus Walleij <linus.walleij@...aro.org>,
 lvzhaoxiong@...qin.corp-partner.google.com, Hsin-Yi Wang
 <hsinyi@...gle.com>, Javier Martinez Canillas <javierm@...hat.com>, Neil
 Armstrong <neil.armstrong@...aro.org>, Joel Selvaraj <jo@...amily.in>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Cong Yang
 <yangcong5@...qin.corp-partner.google.com>, Sam Ravnborg
 <sam@...nborg.org>, Douglas Anderson <dianders@...omium.org>, Daniel
 Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>, Jessica Zhang
 <quic_jesszhan@...cinc.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/8] drm/mipi-dsi: Reduce bloat and add funcs for
 cleaner init seqs

On Fri, 26 Apr 2024, Douglas Anderson <dianders@...omium.org> wrote:
> The consensus of many DRM folks is that we want to move away from DSI
> drivers defining tables of init commands. Instead, we want to move to
> init functions that can use common DRM functions. The issue thus far
> has been that using the macros mipi_dsi_generic_write_seq() and
> mipi_dsi_dcs_write_seq() bloats the driver using them.
>
> While trying to solve bloat, we realized that the majority of the it
> was easy to solve. This series solves the bloat for existing drivers
> by moving the printout outside of the macro.
>
> During discussion of my v1 patch to fix the bloat [1], we also decided
> that we really want to change the way that drivers deal with init
> sequences to make it clearer. In addition to being cleaner, a side
> effect of moving drivers to the new style reduces bloat _even more_.
>
> This series also contains a few minor fixes / cleanups that I found
> along the way.

FWIW, I like the general approach taken here. Thanks!

BR,
Jani.


-- 
Jani Nikula, Intel