linux-kernel - Re: [PATCH 1/2] regulator: dt-bindings: rtq2208: Add property to get ldo of RTQ2208 is adjustable or not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b86b755-62cf-4990-9c7c-29444038d17f@linaro.org>
Date: Mon, 29 Apr 2024 12:37:32 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alina Yu <alina_yu@...htek.com>, lgirdwood@...il.com, broonie@...nel.org,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 johnny_lai@...htek.com, cy_huang@...htek.com
Subject: Re: [PATCH 1/2] regulator: dt-bindings: rtq2208: Add property to get
 ldo of RTQ2208 is adjustable or not

On 29/04/2024 12:16, Alina Yu wrote:
> Since there is no way to check is ldo is adjustable or not.
> 'richtek,use-fix-dvs' is added for that. user is supposed to know whether vout of ldo is adjustable.

1. Please wrap commit message according to Linux coding style /
submission process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

2. Start sentences with capital letters. LDO is acronym.

3. Constraints already tell you that, don't they? Explain why they are
not enough and you need new property.

> 
> Signed-off-by: Alina Yu <alina_yu@...htek.com>
> ---
>  .../devicetree/bindings/regulator/richtek,rtq2208.yaml         | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml
> index 609c066..3951679 100644
> --- a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml
> +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml
> @@ -75,6 +75,14 @@ properties:
>          description:
>            regulator description for ldo[1-2].
>  
> +        properties:
> +          richtek,use-fix-dvs:
> +            type: boolean
> +            description: |
> +              ldo vout ability is determined by this setting. If it's set, the voltage is unadjustable.
> +              There is no risk-free method for software to determine whether the ldo vout is fixed or not.
> +              Therefore, it can only be done in this way.

Wrap according to Linux style (as expressed in Linux coding style document).


Best regards,
Krzysztof