linux-kernel - Re: [PATCH v1 1/1] iommu/amd: Fix compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Apr 2024 09:09:59 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Vasant Hegde <vasant.hegde@....com>, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	Joerg Roedel <joro@...tes.org>,
	Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
	Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] iommu/amd: Fix compilation error

On Mon, Apr 29, 2024 at 02:17:07PM +0300, Andy Shevchenko wrote:
> With WERROR=y, which is default, clang is not happy:
> 
> .../amd/pasid.c:168:3: error: call to undeclared function 'mmu_notifier_unregister'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> .../amd/pasid.c:191:8: error: call to undeclared function 'mmu_notifier_register'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 2 errors generated.
> 
> Select missed dependency.
> 
> Fixes: a5a91e54846d ("iommu/amd: Add SVA domain support")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/iommu/amd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason