linux-kernel - Re: [PATCH] platform/x86/fujitsu-laptop: Replace sprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e27438f-8f96-43fc-afa3-b2e34817a0fd@linux.intel.com>
Date: Sun, 28 Apr 2024 20:17:26 -0700
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
To: Szilard Fabian <szfabian@...emarch.art>, linux-kernel@...r.kernel.org,
 platform-driver-x86@...r.kernel.org, jwoithe@...t42.net,
 hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com
Subject: Re: [PATCH] platform/x86/fujitsu-laptop: Replace sprintf() with
 sysfs_emit()

Hi,

On 4/28/24 12:26 PM, Szilard Fabian wrote:
> As suggested by Documentation/filesystems/sysfs.rst sysfs_emit() should be
> used when formatting the value to be returned to user space.
>
> Signed-off-by: Szilard Fabian <szfabian@...emarch.art>
> ---

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>

>  drivers/platform/x86/fujitsu-laptop.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 94480af49467..968fc91bd5e4 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -386,11 +386,11 @@ static ssize_t lid_show(struct device *dev, struct device_attribute *attr,
>  	struct fujitsu_laptop *priv = dev_get_drvdata(dev);
>  
>  	if (!(priv->flags_supported & FLAG_LID))
> -		return sprintf(buf, "unknown\n");
> +		return sysfs_emit(buf, "unknown\n");
>  	if (priv->flags_state & FLAG_LID)
> -		return sprintf(buf, "open\n");
> +		return sysfs_emit(buf, "open\n");
>  	else
> -		return sprintf(buf, "closed\n");
> +		return sysfs_emit(buf, "closed\n");
>  }
>  
>  static ssize_t dock_show(struct device *dev, struct device_attribute *attr,
> @@ -399,11 +399,11 @@ static ssize_t dock_show(struct device *dev, struct device_attribute *attr,
>  	struct fujitsu_laptop *priv = dev_get_drvdata(dev);
>  
>  	if (!(priv->flags_supported & FLAG_DOCK))
> -		return sprintf(buf, "unknown\n");
> +		return sysfs_emit(buf, "unknown\n");
>  	if (priv->flags_state & FLAG_DOCK)
> -		return sprintf(buf, "docked\n");
> +		return sysfs_emit(buf, "docked\n");
>  	else
> -		return sprintf(buf, "undocked\n");
> +		return sysfs_emit(buf, "undocked\n");
>  }
>  
>  static ssize_t radios_show(struct device *dev, struct device_attribute *attr,
> @@ -412,11 +412,11 @@ static ssize_t radios_show(struct device *dev, struct device_attribute *attr,
>  	struct fujitsu_laptop *priv = dev_get_drvdata(dev);
>  
>  	if (!(priv->flags_supported & FLAG_RFKILL))
> -		return sprintf(buf, "unknown\n");
> +		return sysfs_emit(buf, "unknown\n");
>  	if (priv->flags_state & FLAG_RFKILL)
> -		return sprintf(buf, "on\n");
> +		return sysfs_emit(buf, "on\n");
>  	else
> -		return sprintf(buf, "killed\n");
> +		return sysfs_emit(buf, "killed\n");
>  }
>  
>  static DEVICE_ATTR_RO(lid);

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer