[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55622c35-badb-4b4c-a91f-e487d9eb8fc2@linaro.org>
Date: Mon, 29 Apr 2024 14:52:08 +0200
From: neil.armstrong@...aro.org
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/12] arm64: dts: qcom: sm8550: move USB graph to the SoC
dtsi
On 29/04/2024 14:43, Dmitry Baryshkov wrote:
> Move the graph connection between USB host, USB SS PHY and DP port to
> the SoC dtsi file. They are linked in hardware in this way.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 13 -------------
> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 13 -------------
> arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 13 -------------
> arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 8 --------
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
> 5 files changed, 4 insertions(+), 47 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> index 12d60a0ee095..f786d9114936 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> @@ -940,7 +940,6 @@ &mdss_dp0 {
> };
>
> &mdss_dp0_out {
> - remote-endpoint = <&usb_dp_qmpphy_dp_in>;
> data-lanes = <0 1>;
> };
>
> @@ -1267,10 +1266,6 @@ &usb_1_dwc3_hs {
> remote-endpoint = <&pmic_glink_hs_in>;
> };
>
> -&usb_1_dwc3_ss {
> - remote-endpoint = <&usb_dp_qmpphy_usb_ss_in>;
> -};
> -
> &usb_1_hsphy {
> vdd-supply = <&vreg_l1e_0p88>;
> vdda12-supply = <&vreg_l3e_1p2>;
> @@ -1289,18 +1284,10 @@ &usb_dp_qmpphy {
> status = "okay";
> };
>
> -&usb_dp_qmpphy_dp_in {
> - remote-endpoint = <&mdss_dp0_out>;
> -};
> -
> &usb_dp_qmpphy_out {
> remote-endpoint = <&pmic_glink_ss_in>;
> };
>
> -&usb_dp_qmpphy_usb_ss_in {
> - remote-endpoint = <&usb_1_dwc3_ss>;
> -};
> -
> &xo_board {
> clock-frequency = <76800000>;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> index 3d4ad5aac70f..56800ab903a1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> @@ -736,7 +736,6 @@ &mdss_dp0 {
>
> &mdss_dp0_out {
> data-lanes = <0 1>;
> - remote-endpoint = <&usb_dp_qmpphy_dp_in>;
> };
>
> &pcie_1_phy_aux_clk {
> @@ -960,10 +959,6 @@ &usb_1_dwc3_hs {
> remote-endpoint = <&pmic_glink_hs_in>;
> };
>
> -&usb_1_dwc3_ss {
> - remote-endpoint = <&usb_dp_qmpphy_usb_ss_in>;
> -};
> -
> &usb_1_hsphy {
> vdd-supply = <&vreg_l1e_0p88>;
> vdda12-supply = <&vreg_l3e_1p2>;
> @@ -982,18 +977,10 @@ &usb_dp_qmpphy {
> status = "okay";
> };
>
> -&usb_dp_qmpphy_dp_in {
> - remote-endpoint = <&mdss_dp0_out>;
> -};
> -
> &usb_dp_qmpphy_out {
> remote-endpoint = <&pmic_glink_ss_in>;
> };
>
> -&usb_dp_qmpphy_usb_ss_in {
> - remote-endpoint = <&usb_1_dwc3_ss>;
> -};
> -
> &xo_board {
> clock-frequency = <76800000>;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> index 92f015017418..d0b373da39d4 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
> @@ -807,7 +807,6 @@ &mdss_dp0 {
>
> &mdss_dp0_out {
> data-lanes = <0 1>;
> - remote-endpoint = <&usb_dp_qmpphy_dp_in>;
> };
>
> &pcie_1_phy_aux_clk {
> @@ -1144,10 +1143,6 @@ &usb_1_dwc3_hs {
> remote-endpoint = <&pmic_glink_hs_in>;
> };
>
> -&usb_1_dwc3_ss {
> - remote-endpoint = <&usb_dp_qmpphy_usb_ss_in>;
> -};
> -
> &usb_1_hsphy {
> vdd-supply = <&vreg_l1e_0p88>;
> vdda12-supply = <&vreg_l3e_1p2>;
> @@ -1166,18 +1161,10 @@ &usb_dp_qmpphy {
> status = "okay";
> };
>
> -&usb_dp_qmpphy_dp_in {
> - remote-endpoint = <&mdss_dp0_out>;
> -};
> -
> &usb_dp_qmpphy_out {
> remote-endpoint = <&redriver_ss_in>;
> };
>
> -&usb_dp_qmpphy_usb_ss_in {
> - remote-endpoint = <&usb_1_dwc3_ss>;
> -};
> -
> &xo_board {
> clock-frequency = <76800000>;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts
> index 85e0d3d66e16..7a8d5c34e9e6 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts
> @@ -746,10 +746,6 @@ &usb_1_dwc3_hs {
> remote-endpoint = <&pmic_glink_hs_in>;
> };
>
> -&usb_1_dwc3_ss {
> - remote-endpoint = <&usb_dp_qmpphy_usb_ss_in>;
> -};
> -
> &usb_1_hsphy {
> vdd-supply = <&pm8550vs_2_l1>;
> vdda12-supply = <&pm8550vs_2_l3>;
> @@ -770,10 +766,6 @@ &usb_dp_qmpphy_out {
> remote-endpoint = <&pmic_glink_ss_in>;
> };
>
> -&usb_dp_qmpphy_usb_ss_in {
> - remote-endpoint = <&usb_1_dwc3_ss>;
> -};
> -
> &xo_board {
> clock-frequency = <76800000>;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index bc5aeb05ffc3..3ada5a30ecb7 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2910,6 +2910,7 @@ mdss_dp0_in: endpoint {
> port@1 {
> reg = <1>;
> mdss_dp0_out: endpoint {
> + remote-endpoint = <&usb_dp_qmpphy_dp_in>;
> };
> };
> };
> @@ -3186,6 +3187,7 @@ port@1 {
> reg = <1>;
>
> usb_dp_qmpphy_usb_ss_in: endpoint {
> + remote-endpoint = <&usb_1_dwc3_ss>;
> };
> };
>
> @@ -3193,6 +3195,7 @@ port@2 {
> reg = <2>;
>
> usb_dp_qmpphy_dp_in: endpoint {
> + remote-endpoint = <&mdss_dp0_out>;
> };
> };
> };
> @@ -3280,6 +3283,7 @@ port@1 {
> reg = <1>;
>
> usb_1_dwc3_ss: endpoint {
> + remote-endpoint = <&usb_dp_qmpphy_usb_ss_in>;
> };
> };
> };
>
Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
Powered by blists - more mailing lists