linux-kernel - Re: [PATCH v2] arm: kasan: clear stale stack poison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f90f5352-30ed-419f-803b-7885b4298868@gmail.com>
Date: Mon, 29 Apr 2024 14:57:35 +0200
From: Andrey Ryabinin <ryabinin.a.a@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>,
 Boy Wu (吳勃誼) <Boy.Wu@...iatek.com>
Cc: "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "andreyknvl@...il.com" <andreyknvl@...il.com>,
 "dvyukov@...gle.com" <dvyukov@...gle.com>,
 "kasan-dev@...glegroups.com" <kasan-dev@...glegroups.com>,
 Iverlin Wang (王苳霖) <Iverlin.Wang@...iatek.com>,
 "mark.rutland@....com" <mark.rutland@....com>,
 Light Chen (陳昱光) <Light.Chen@...iatek.com>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, "glider@...gle.com"
 <glider@...gle.com>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 "vincenzo.frascino@....com" <vincenzo.frascino@....com>,
 "angelogioacchino.delregno@...labora.com"
 <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v2] arm: kasan: clear stale stack poison



On 4/29/24 14:42, Russell King (Oracle) wrote:
> On Mon, Apr 29, 2024 at 07:51:49AM +0000, Boy Wu (吳勃誼) wrote:
>> On Sun, 2024-04-28 at 15:45 +0100, Russell King (Oracle) wrote:
>>>  On Fri, Apr 12, 2024 at 10:37:06AM +0200, Linus Walleij wrote:
>>>> On Wed, Apr 10, 2024 at 9:31 AM boy.wu <boy.wu@...iatek.com> wrote:
>>>>
>>>>> From: Boy Wu <boy.wu@...iatek.com>
>>>>>
>>>>> We found below OOB crash:
>>>>
>>>> Thanks for digging in!
>>>>
>>>> Pleas put this patch into Russell's patch tracker so he can apply
>>> it:
>>>> https://www.armlinux.org.uk/developer/patches/
>>>
>>> Is this a bug fix? If so, having a Fixes: tag would be nice...
>>>
>>
>> This is a patch for cpuidle flow when KASAN enable, that is in ARM64
>> but not in ARM, so add to ARM.
>>
>> The reference commits did not mention fix any commits.
>> [1] commit 0d97e6d8024c ("arm64: kasan: clear stale stack poison")
>> [2] commit d56a9ef84bd0 ("kasan, arm64: unpoison stack only with
>> CONFIG_KASAN_STACK")
> 
> These are not suitable for use as a Fixes: tag because these commits
> refer to code in another part of the tree that has nothing to do with
> the BUG() dump that is contained within your commit message.
> 
> I ask again... Is this a bug fix?
> 
> Is it a regression?
> 
> Is it something that used to work that no longer works?
> 
> When did it break?
> 
> Has it always been broken?
> 
> Has it been broken since KASAN was introduced on 32-bit ARM?
> 

Yes, this is a bug fix and it has been broken since KASAN was introduced on 32-bit ARM.
So, I think this should be
	Fixes: 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow memory")