linux-kernel - Re: [PATCH net] net: prevent pulling SKB_GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240429064209.5ce59350@kernel.org>
Date: Mon, 29 Apr 2024 06:42:09 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <shiming.cheng@...iatek.com>
Cc: <willemdebruijn.kernel@...il.com>, <edumazet@...gle.com>,
 <davem@...emloft.net>, <pabeni@...hat.com>, <matthias.bgg@...il.com>,
 <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, Lena Wang
 <lena.wang@...iatek.com>
Subject: Re: [PATCH net] net: prevent pulling SKB_GSO_FRAGLIST skb

On Sun, 28 Apr 2024 22:29:13 +0800 shiming.cheng@...iatek.com wrote:
> From: Shiming Cheng <shiming.cheng@...iatek.com>
> 
> BPF or TC callers may pull in a length longer than skb_headlen()
> for a SKB_GSO_FRAGLIST skb. The data in fraglist will be pulled
> into the linear space. However it destroys the skb's structure
> and may result in an invalid segmentation or kernel exception.
> 
> So we should add protection to stop the operation and return
> error to remind callers.

One of the fixes you posted breaks the

  tools/testing/selftests/net/udpgro_fwd.sh

selftest. Please investigate, and either adjust the test or the fix.