linux-kernel - Re: [PATCH v2 2/3] thermal: intel: intel_tcc_cooling: Use a model-specific bitmask for TCC offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5de7a9cf7336afa4aa514d93ba9bcd0bac3ef8f0.camel@intel.com>
Date: Mon, 29 Apr 2024 14:39:14 +0000
From: "Zhang, Rui" <rui.zhang@...el.com>
To: "linux@...ck-us.net" <linux@...ck-us.net>,
	"ricardo.neri-calderon@...ux.intel.com"
	<ricardo.neri-calderon@...ux.intel.com>, "Wysocki, Rafael J"
	<rafael.j.wysocki@...el.com>, "jdelvare@...e.com" <jdelvare@...e.com>
CC: "srinivas.pandruvada@...ux.intel.com"
	<srinivas.pandruvada@...ux.intel.com>, "lukasz.luba@....com"
	<lukasz.luba@....com>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Neri,
 Ricardo" <ricardo.neri@...el.com>
Subject: Re: [PATCH v2 2/3] thermal: intel: intel_tcc_cooling: Use a
 model-specific bitmask for TCC offset

On Thu, 2024-04-25 at 10:13 -0700, Ricardo Neri wrote:
> The TCC offset field in the register MSR_TEMPERATURE_TARGET is not
> architectural. The TCC library provides a model-specific bitmask. Use
> it to
> determine the maximum TCC offset.
> 
> Suggested-by: Zhang Rui <rui.zhang@...el.com>
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>

Reviewed-by: Zhang Rui <rui.zhang@...el.com>

-rui

> ---
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Lukasz Luba <lukasz.luba@....com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: linux-hwmon@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: stable@...r.kernel.org # v6.7+
> ---
> Changes since v1:
>  * Used renamed function intel_tcc_get_offset_mask().
> ---
>  drivers/thermal/intel/intel_tcc_cooling.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/intel/intel_tcc_cooling.c
> b/drivers/thermal/intel/intel_tcc_cooling.c
> index 6c392147e6d1..5bfc2b515c78 100644
> --- a/drivers/thermal/intel/intel_tcc_cooling.c
> +++ b/drivers/thermal/intel/intel_tcc_cooling.c
> @@ -20,7 +20,7 @@ static struct thermal_cooling_device *tcc_cdev;
>  static int tcc_get_max_state(struct thermal_cooling_device *cdev,
> unsigned long
>                              *state)
>  {
> -       *state = 0x3f;
> +       *state = intel_tcc_get_offset_mask();
>         return 0;
>  }
>