linux-kernel - Re: [PATCH RFC] i2c: Add a void pointer to i2c_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zi-57cHtEelQiVEg@smile.fi.intel.com>
Date: Mon, 29 Apr 2024 18:17:01 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	linux-i2c@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH RFC] i2c: Add a void pointer to i2c_device_id

On Mon, Apr 29, 2024 at 03:55:57PM +0200, Uwe Kleine-König wrote:
> On Mon, Apr 29, 2024 at 01:28:32PM +0300, Andy Shevchenko wrote:

..

> OK, agreed. I'm not sure yet if I prefer
> 
> 	static const struct i2c_device_id wlf_gf_module_id[] = {
> 		{ "wlf-gf-module" },
> 		{ }
> 	};
> 
> or
> 
> 	static const struct i2c_device_id wlf_gf_module_id[] = {
> 		{ .name = "wlf-gf-module" },
> 		{ }
> 	};

Personally I don't care, but it seems in such cases the .name is too verbose
for no benefit. If one needs to expand this with driver data they will change
that line in any case.

-- 
With Best Regards,
Andy Shevchenko