linux-kernel - Re: [PATCH v2 8/9] selftests/harness: Share

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202404290856.494B7F8A@keescook>
Date: Mon, 29 Apr 2024 08:56:56 -0700
From: Kees Cook <keescook@...omium.org>
To: Mickaël Salaün <mic@...ikod.net>
Cc: Christian Brauner <brauner@...nel.org>,
	Jakub Kicinski <kuba@...nel.org>, Mark Brown <broonie@...nel.org>,
	Shengyu Li <shengyu.li.evgeny@...il.com>,
	Shuah Khan <shuah@...nel.org>,
	"David S . Miller" <davem@...emloft.net>,
	Günther Noack <gnoack@...gle.com>,
	Will Drewry <wad@...omium.org>,
	kernel test robot <oliver.sang@...el.com>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 8/9] selftests/harness: Share _metadata between forked
 processes

On Mon, Apr 29, 2024 at 03:09:30PM +0200, Mickaël Salaün wrote:
> Unconditionally share _metadata between all forked processes, which
> enables to actually catch errors which were previously ignored.
> 
> This is required for a following commit replacing vfork() with clone3()
> and CLONE_VFORK (i.e. not sharing the full memory) .  It should also be
> useful to share _metadata to extend expectations to test process's
> forks.  For instance, this change identified a wrong expectation in
> pidfd_setns_test.
> 
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> Cc: Will Drewry <wad@...omium.org>
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook