linux-kernel - Re: [PATCH] clk: imx: imx8mp: Add missing CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240430144044.35561-A-hca@linux.ibm.com>
Date: Tue, 30 Apr 2024 16:40:44 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: linux-s390@...r.kernel.org, open list <linux-kernel@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>, lkft-triage@...ts.linaro.org,
        Linux Regressions <regressions@...ts.linux.dev>, imx@...ts.linux.dev,
        Abel Vesa <abelvesa@...nel.org>, Abel Vesa <abel.vesa@...aro.org>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Shengjiu Wang <shengjiu.wang@....com>, Shawn Guo <shawnguo@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        Anders Roxell <anders.roxell@...aro.org>, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH] clk: imx: imx8mp: Add missing CONFIG_PM ifdefs

On Tue, Apr 30, 2024 at 04:30:37PM +0200, Arnd Bergmann wrote:
> On Tue, Apr 30, 2024, at 16:16, Heiko Carstens wrote:
> > Add missing CONFIG_PM ifdefs to fix this allmodconfig compile error:
> >
> > drivers/clk/imx/clk-imx8mp-audiomix.c:356:12: error:
> > 'clk_imx8mp_audiomix_runtime_suspend' defined but not used
> > [-Werror=unused-function]
> >   356 | static int clk_imx8mp_audiomix_runtime_suspend(struct device *dev)
> >       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> > Closes: 
> > https://lore.kernel.org/r/CA+G9fYuP7S+a89Ep5g5_Ad69EMwRkJ8nM+MMTzbEcP+6H2oMXQ@mail.gmail.com
> > Fixes: 1496dd413b2e ("clk: imx: imx8mp: Add pm_runtime support for 
> > power saving")
> > Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> 
> Thanks for your patch. I see the bug as well, but
> I think a better fix is to replace the deprecated
> SET_RUNTIME_PM_OPS() and SET_NOIRQ_SYSTEM_SLEEP_PM_OPS()
> with the modern variants, RUNTIME_PM_OPS() and
> RUNTIME_PM_OPS().

Fine with me, I leave that up to the original author then.