linux-kernel - Re: [PATCH 1/2] dt-bindings: power: supply: max8903: specify flt-gpios as input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <n7mahydeipds3zwynt73gpfrujsu54yo7xwztesqrxem7eumqk@7wa6nhm6iyfc>
Date: Tue, 30 Apr 2024 16:51:42 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Conor Dooley <conor@...nel.org>
Cc: Herman van Hazendonk <github.com@...rie.org>, benwolsieffer@...il.com, 
	chris.chapuis@...il.com, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-pm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: max8903: specify
 flt-gpios as input

Hi,

On Mon, Apr 15, 2024 at 05:28:22PM +0100, Conor Dooley wrote:
> On Mon, Apr 15, 2024 at 05:16:45PM +0200, Herman van Hazendonk wrote:
> > The FLT pin was incorrected documented as an output. The MAX8903 uses it to
> > signal to the processor that a charging fault has occurred.
> 
> I guess this is just a matter of framing? Input to the hardware running
> the OS but an output from the max8903?
> 
> I'm okay with whatever wording causing less confusion, which may mean
> something that specifics what this is relative to?

well, this definitely improves things, since the other GPIOs
from the same file are all described with the hardware running
the OS being the reference. So this makes things at least
uniform.

> > 
> > Signed-off-by: Herman van Hazendonk <github.com@...rie.org>
> 
> The SoB email should match the from email fyi.

It does for this patch, so I took it.

Greetings,

-- Sebastian

> Cheers,
> Conor.
> 
> > ---
> >  .../devicetree/bindings/power/supply/maxim,max8903.yaml         | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> > index a8d625f285f1..86af38378999 100644
> > --- a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> > @@ -34,7 +34,7 @@ properties:
> >  
> >    flt-gpios:
> >      maxItems: 1
> > -    description: Fault pin (active low, output)
> > +    description: Fault pin (active low, input)
> >  
> >    dcm-gpios:
> >      maxItems: 1



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)