linux-kernel - Re: [PATCH v6 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202404302343.PSH0M0Cy-lkp@intel.com>
Date: Tue, 30 Apr 2024 23:36:07 +0800
From: kernel test robot <lkp@...el.com>
To: Vamsi Attunuru <vattunuru@...vell.com>, arnd@...db.de,
	gregkh@...uxfoundation.org
Cc: oe-kbuild-all@...ts.linux.dev, vattunuru@...vell.com,
	jerinj@...vell.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI
 administrative driver

Hi Vamsi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus soc/for-next linus/master v6.9-rc6 next-20240430]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vamsi-Attunuru/misc-mrvl-cn10k-dpi-add-Octeon-CN10K-DPI-administrative-driver/20240430-142354
base:   char-misc/char-misc-testing
patch link:    https://lore.kernel.org/r/20240429055027.2162310-1-vattunuru%40marvell.com
patch subject: [PATCH v6 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver
config: m68k-m5208evb_defconfig (https://download.01.org/0day-ci/archive/20240430/202404302343.PSH0M0Cy-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240430/202404302343.PSH0M0Cy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404302343.PSH0M0Cy-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/misc/mrvl_cn10k_dpi.c:197:9: warning: 'packed' attribute ignored for field of type 'struct dpi_mbox_message_s' [-Wattributes]
     197 |         } s __packed;
         |         ^
   drivers/misc/mrvl_cn10k_dpi.c: In function 'dpi_reg_write':
   drivers/misc/mrvl_cn10k_dpi.c:202:9: error: implicit declaration of function 'writeq'; did you mean 'writeb'? [-Werror=implicit-function-declaration]
     202 |         writeq(val, dpi->reg_base + offset);
         |         ^~~~~~
         |         writeb
   drivers/misc/mrvl_cn10k_dpi.c: In function 'dpi_reg_read':
   drivers/misc/mrvl_cn10k_dpi.c:207:16: error: implicit declaration of function 'readq'; did you mean 'readb'? [-Werror=implicit-function-declaration]
     207 |         return readq(dpi->reg_base + offset);
         |                ^~~~~
         |                readb
   drivers/misc/mrvl_cn10k_dpi.c: In function 'dpi_free_irq_vectors':
   drivers/misc/mrvl_cn10k_dpi.c:453:9: error: implicit declaration of function 'pci_free_irq_vectors'; did you mean 'dpi_free_irq_vectors'? [-Werror=implicit-function-declaration]
     453 |         pci_free_irq_vectors((struct pci_dev *)pdev);
         |         ^~~~~~~~~~~~~~~~~~~~
         |         dpi_free_irq_vectors
   In file included from include/uapi/linux/posix_types.h:5,
                    from include/uapi/linux/types.h:14,
                    from include/linux/types.h:6,
                    from include/linux/compat.h:9,
                    from drivers/misc/mrvl_cn10k_dpi.c:8:
   drivers/misc/mrvl_cn10k_dpi.c: In function 'dpi_remove':
   include/linux/stddef.h:8:14: error: called object is not a function or function pointer
       8 | #define NULL ((void *)0)
         |              ^
   include/linux/pci.h:2445:41: note: in expansion of macro 'NULL'
    2445 | #define pci_sriov_configure_simple      NULL
         |                                         ^~~~
   drivers/misc/mrvl_cn10k_dpi.c:661:9: note: in expansion of macro 'pci_sriov_configure_simple'
     661 |         pci_sriov_configure_simple(pdev, 0);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/misc/mrvl_cn10k_dpi.c: At top level:
   drivers/misc/mrvl_cn10k_dpi.c:681:1: warning: data definition has no type or storage class
     681 | module_pci_driver(dpi_driver);
         | ^~~~~~~~~~~~~~~~~
   drivers/misc/mrvl_cn10k_dpi.c:681:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int]
   drivers/misc/mrvl_cn10k_dpi.c:681:1: warning: parameter names (without types) in function declaration
   drivers/misc/mrvl_cn10k_dpi.c:673:26: warning: 'dpi_driver' defined but not used [-Wunused-variable]
     673 | static struct pci_driver dpi_driver = {
         |                          ^~~~~~~~~~
   cc1: some warnings being treated as errors


vim +197 drivers/misc/mrvl_cn10k_dpi.c

   175	
   176	union dpi_mbox_message_t {
   177		u64 u[2];
   178		struct dpi_mbox_message_s {
   179			/* VF ID to configure */
   180			u64 vfid           :8;
   181			/* Command code */
   182			u64 cmd            :4;
   183			/* Command buffer size in 8-byte words */
   184			u64 csize          :14;
   185			/* Aura of the command buffer */
   186			u64 aura           :20;
   187			/* SSO PF function */
   188			u64 sso_pf_func    :16;
   189			/* NPA PF function */
   190			u64 npa_pf_func    :16;
   191			/* Work queue completion status enable */
   192			u64 wqecs	:1;
   193			/* Work queue completion status byte offset */
   194			u64 wqecsoff	:7;
   195			/* Reserved */
   196			u64 rsvd	:42;
 > 197		} s __packed;
   198	};
   199	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki