linux-kernel - Re: [EXTERNAL] [PATCH v3 05/12] cifs: drop usage of page_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMgjq7ADnn+uEL0jY676rk6+9cFWgrZxMCZ2m2qf1GM87Eav9Q@mail.gmail.com>
Date: Tue, 30 Apr 2024 23:40:43 +0800
From: Kairui Song <ryncsn@...il.com>
To: Steven French <Steven.French@...rosoft.com>
Cc: "linux-mm@...ck.org" <linux-mm@...ck.org>, Andrew Morton <akpm@...ux-foundation.org>, 
	"Huang, Ying" <ying.huang@...el.com>, Matthew Wilcox <willy@...radead.org>, Chris Li <chrisl@...nel.org>, 
	Barry Song <v-songbaohua@...o.com>, Ryan Roberts <ryan.roberts@....com>, Neil Brown <neilb@...e.de>, 
	Minchan Kim <minchan@...nel.org>, Hugh Dickins <hughd@...gle.com>, 
	David Hildenbrand <david@...hat.com>, Yosry Ahmed <yosryahmed@...gle.com>, 
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Namjae Jeon <linkinjeon@...nel.org>, 
	"Paulo Alcantara (SUSE)" <pc@...guebit.com>, Shyam Prasad <Shyam.Prasad@...rosoft.com>, 
	Bharath S M <bharathsm@...rosoft.com>
Subject: Re: [EXTERNAL] [PATCH v3 05/12] cifs: drop usage of page_file_offset

On Tue, Apr 30, 2024 at 4:19 AM Steven French
<Steven.French@...rosoft.com> wrote:
>
> Wouldn't this make it harder to fix the regression when swap file support was temporarily removed from cifs.ko (due to the folio migration)?   I was hoping to come back to fixing swapfile support for cifs.ko in 6.10-rc (which used to pass the various xfstests for this but code got removed with folios/netfs changes).
>

Hi Steven,

I think this won't cause any trouble for that, the new swap_rw
interface should have splitted the swap cache from fs side, which made
the code struct cleaner, and I think that's the right path. NFS is
using that already. With this interface, .read_folio (cifs_read_folio)
should never be called for swap cache folios.