linux-kernel - Re: [RFC] crypto: passing configuration parameters to comp algos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240430031847.GB10165@sol.localdomain>
Date: Mon, 29 Apr 2024 20:18:47 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] crypto: passing configuration parameters to comp algos

On Tue, Apr 30, 2024 at 12:04:47PM +0900, Sergey Senozhatsky wrote:
> Hi,
> 
> 	We'd like to be able to pass algorithm-specific parameters to
> comp backends. As of this moment, crypto usees hard-coded default
> values and does not permit any run-time algorithm configuration,
> which in some cases simply disables the most interesting functionality.
> E.g. zstd can be configured to use a pre-trained (in the user-space)
> compression dictionary, which significantly changes algorithms
> characteristics. Another, obvious and trivial example, is algorithms
> compression level.
> 
> The problem is that we need to pass params to cra_init() function,
> because for some algorithms that's the only place where configuration
> can take place (e.g. zstd). Changing cra_init() to accept additional
> `struct crypto_comp_params` looks to be a little intrusive so before
> I write any patches I'd like to hear your thoughts.
> 

Have you considered just using the zstd library (<linux/zstd.h>) directly?

Which kernel subsystem are you working on that uses compression?

- Eric