[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZjEZTfU-u6m5Fx7a@bogus>
Date: Tue, 30 Apr 2024 17:16:13 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc: Linux ACPI <linux-acpi@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Sudeep Holla <sudeep.holla@....com>,
Salil Mehta <salil.mehta@...wei.com>,
Jonathan Cameron <jonathan.cameron@...wei.com>,
Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH v2] ACPI: scan: Avoid enumerating devices with clearly
invalid _STA values
On Tue, Apr 30, 2024 at 06:02:20PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> The return value of _STA with the "present" bit unset and the "enabled"
> bit set is clearly invalid as per the ACPI specification, Section 6.3.7
> "_STA (Device Status)", so make the ACPI device enumeration code
> disregard devices with such _STA return values.
>
> Also, because this implies that status.enabled will only be set if
> status.present is set too, acpi_device_is_enabled() can be modified
> to simply return the value of the former.
>
Nice!
FWIW,
Reviewed-by: Sudeep Holla <sudeep.holla@....com>
--
Regards,
Sudeep
Powered by blists - more mailing lists