linux-kernel - Re: [PATCH v7 1/2] dt-bindings: media: rockchip-vpu: Add rk3588 vpu121 compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59899cfa3d3245309ce6952ae1028dceae27b488.camel@ndufresne.ca>
Date: Tue, 30 Apr 2024 12:21:21 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Jianfeng Liu <liujianfeng1994@...il.com>, linux-media@...r.kernel.org, 
	linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: ezequiel@...guardiasur.com.ar, p.zabel@...gutronix.de,
 mchehab@...nel.org,  robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, heiko@...ech.de,  sebastian.reichel@...labora.com,
 sfr@...b.auug.org.au, sigmaris@...il.com,  linkmauve@...kmauve.fr, Conor
 Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v7 1/2] dt-bindings: media: rockchip-vpu: Add rk3588
 vpu121 compatible string

Hi,

Le mardi 30 avril 2024 à 10:40 +0800, Jianfeng Liu a écrit :
> Add Hantro G1 VPU compatible string for RK3588.
> RK3588 has the same Hantro G1 ip as RK3568, which are both
> known as VDPU121 in TRM of RK3568 and RK3588.
> 
> Note that this VPU also has a jpeg encoder, which is one part of
> the five VEPU121 jpeg encoders on RK3588. So this VPU121 shoud be
> the same as vpu@...50000 on RK3399. But we don't use the compatible
> string rk3399-vpu because of two reasons:
> 1, rk3399-vpu has disabled H264 decoding because RK3399 also has
> rkvdec to support 4K H264 decoding. And we need H264 decoding because
> rkvdec2 on rk3588 for H264 decoding is not supported now.
> 2, There are five VEPU121 jpeg encoders, but the kernel driver can't
> do scheduling. So it's better to disable the VEPU121 jpeg encoder
> at the moment.
> 
> Signed-off-by: Jianfeng Liu <liujianfeng1994@...il.com>
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> ---
>  Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> index c57e1f488..2710bb2fb 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> @@ -31,6 +31,9 @@ properties:
>        - items:
>            - const: rockchip,rk3228-vpu
>            - const: rockchip,rk3399-vpu
> +      - items:
> +          - const: rockchip,rk3588-vpu121
> +          - const: rockchip,rk3568-vpu

Sorry to come that late, but I'm noticing a big mistake here. You said you are
enabling VDPU121, the JPEG decoder. But we don't have a JPEG decoder driver
mainline, is there some patches missing ?

Nicolas

> 
>    reg:
>      maxItems: 1
> --
> 2.34.1
>