[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202405010052.Cxh2bazm-lkp@intel.com>
Date: Wed, 1 May 2024 00:27:54 +0800
From: kernel test robot <lkp@...el.com>
To: lakshmi.sowjanya.d@...el.com, tglx@...utronix.de, jstultz@...gle.com,
giometti@...eenne.com, corbet@....net, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, christopher.s.hall@...el.com,
subramanian.mohan@...el.com, lakshmi.sowjanya.d@...el.com,
linux-doc@...r.kernel.org, netdev@...r.kernel.org,
pandith.n@...el.com, x86@...nel.org, eddie.dong@...el.com,
linux-sound@...r.kernel.org, alexandre.torgue@...s.st.com,
peter.hilber@...nsynergy.com, joabreu@...opsys.com,
intel-wired-lan@...ts.osuosl.org, mcoquelin.stm32@...il.com,
thejesh.reddy.t.r@...el.com, perex@...ex.cz,
anthony.l.nguyen@...el.com, andriy.shevchenko@...ux.intel.com,
davem@...emloft.net
Subject: Re: [Intel-wired-lan] [PATCH v7 09/12] timekeeping: Add function to
convert realtime to base clock
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/timers/core]
[also build test WARNING on tnguy-next-queue/dev-queue tnguy-net-queue/dev-queue linus/master v6.9-rc6 next-20240430]
[cannot apply to tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/lakshmi-sowjanya-d-intel-com/timekeeping-Add-base-clock-properties-in-clocksource-structure/20240430-165602
base: tip/timers/core
patch link: https://lore.kernel.org/r/20240430085225.18086-10-lakshmi.sowjanya.d%40intel.com
patch subject: [Intel-wired-lan] [PATCH v7 09/12] timekeeping: Add function to convert realtime to base clock
config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240501/202405010052.Cxh2bazm-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240501/202405010052.Cxh2bazm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405010052.Cxh2bazm-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/time/timekeeping.c:1271: warning: Function parameter or struct member 'cycles' not described in 'ktime_real_to_base_clock'
kernel/time/timekeeping.c:2547: warning: Function parameter or struct member 'txc' not described in 'do_adjtimex'
kernel/time/timekeeping.c:2615: warning: Function parameter or struct member 'phase_ts' not described in 'hardpps'
kernel/time/timekeeping.c:2615: warning: Function parameter or struct member 'raw_ts' not described in 'hardpps'
vim +1271 kernel/time/timekeeping.c
1259
1260 /**
1261 * ktime_real_to_base_clock() - Convert CLOCK_REALTIME timestamp to a base clock timestamp
1262 * @treal: CLOCK_REALTIME timestamp to convert
1263 * @base_id: base clocksource id
1264 * @*cycles: pointer to store the converted base clock timestamp
1265 *
1266 * Converts a supplied, future realtime clock value to the corresponding base clock value.
1267 *
1268 * Return: true if the conversion is successful, false otherwise.
1269 */
1270 bool ktime_real_to_base_clock(ktime_t treal, enum clocksource_ids base_id, u64 *cycles)
> 1271 {
1272 struct timekeeper *tk = &tk_core.timekeeper;
1273 unsigned int seq;
1274 u64 delta;
1275
1276 do {
1277 seq = read_seqcount_begin(&tk_core.seq);
1278 if ((u64)treal < tk->tkr_mono.base_real)
1279 return false;
1280 delta = (u64)treal - tk->tkr_mono.base_real;
1281 if (!convert_ns_to_cs(&delta))
1282 return false;
1283 *cycles = tk->tkr_mono.cycle_last + delta;
1284 if (!convert_cs_to_base(cycles, base_id))
1285 return false;
1286 } while (read_seqcount_retry(&tk_core.seq, seq));
1287
1288 return true;
1289 }
1290 EXPORT_SYMBOL_GPL(ktime_real_to_base_clock);
1291
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists