linux-kernel - Re: [PATCH v3 0/9] Fix Kselftest's vfork() side effects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202404300949.28CC6811C0@keescook>
Date: Tue, 30 Apr 2024 09:50:11 -0700
From: Kees Cook <keescook@...omium.org>
To: Mickaël Salaün <mic@...ikod.net>
Cc: Jakub Kicinski <kuba@...nel.org>, Shuah Khan <shuah@...nel.org>,
	Mark Brown <broonie@...nel.org>,
	Christian Brauner <brauner@...nel.org>,
	Shengyu Li <shengyu.li.evgeny@...il.com>,
	"David S . Miller" <davem@...emloft.net>,
	Günther Noack <gnoack@...gle.com>,
	Will Drewry <wad@...omium.org>,
	kernel test robot <oliver.sang@...el.com>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v3 0/9] Fix Kselftest's vfork() side effects

On Tue, Apr 30, 2024 at 06:38:40PM +0200, Mickaël Salaün wrote:
> On Tue, Apr 30, 2024 at 08:13:04AM -0700, Jakub Kicinski wrote:
> > On Tue, 30 Apr 2024 15:54:38 +0200 Mickaël Salaün wrote:
> > > Jakub, can you please review it?
> > 
> > I looked thru it. I don't have the cycles to investigate and suggest 
> > a better approach but the sprinkling of mmaps(), if nothing else, feels
> > a bit band-aid-y 🤷️
> 
> The only mmap that could have side effects on existing tests in the
> _metadata one, but in fact it would reveal issues in tests, so at the
> end I think it's a good thing.
> 
> I'd like "self" to not be conditionally shared but that would require
> changes in several tests.  Let's keep that for another release. :)
> 
> I also noticed that mmap() is already used in test_harness_run() with
> results.

Yeah, I was initially worried about adding this complexity, but at the
end of the day it actually makes things more robust. I'm in favor of it.

-Kees

-- 
Kees Cook