linux-kernel - Re: [PATCH] selftests/kcmp: Remove unused open mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 30 Apr 2024 20:47:58 +0300
From: Cyrill Gorcunov <gorcunov@...il.com>
To: Edward Liaw <edliaw@...gle.com>
Cc: linux-kernel@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kselftest@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH] selftests/kcmp: Remove unused open mode

On Mon, Apr 29, 2024 at 11:46:09PM +0000, Edward Liaw wrote:
> Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE
> aren't specified.  The permissions for the file are set above:
> 
> 	fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644);
> 
> Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall")
> Signed-off-by: Edward Liaw <edliaw@...gle.com>

Thanks!

Reviewed-by: Cyrill Gorcunov <gorcunov@...il.com>