linux-kernel - Re: [PATCH] mptcp: subflow.c: fix typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240430180057.GB2575892@kernel.org>
Date: Tue, 30 Apr 2024 19:00:57 +0100
From: Simon Horman <horms@...nel.org>
To: Shi-Sheng Yang <fourcolor4c@...il.com>
Cc: matttbe@...nel.org, martineau@...nel.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	geliang@...nel.org, netdev@...r.kernel.org, mptcp@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Shi-Sheng Yang <james1qaz2wsx12qw@...il.com>
Subject: Re: [PATCH] mptcp: subflow.c: fix typo

On Tue, Apr 30, 2024 at 06:50:33AM +0800, Shi-Sheng Yang wrote:
> Replace 'greceful' with 'graceful'.
> 
> Signed-off-by: Shi-Sheng Yang <james1qaz2wsx12qw@...il.com>

Hi Shi-Sheng Yang,

Elsewhere in the same file 'earlier' is mispelt as 'eariler'.
Could you consider fixing that too?

Better still, could you consider running codespell over
net/mptcp/ and fixing (the non false-positives) that it flags?

If you do repost then I think an appropriate prefix
would be 'mctp: ' rather than 'mctp: subflow.c ',
as this follows the pattern in git history.

And I think the target tree should be net-next.
That is, the patch should be based on net-next and
it should be designated in the subject.

e.g. Subject: [PATCH v2 net-next] mptcp: fix typos in comments

Lastly, please keep in mind that 24h should elapse
before posting a new version.

Link: https://docs.kernel.org/process/maintainer-netdev.html

..