linux-kernel - Re: [GIT PULL fixes PATCH] clk: samsung: Revert "clk: Use device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ce3c1873130ff696101f781b4df239b.sboyd@kernel.org>
Date: Tue, 30 Apr 2024 14:24:47 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Michael Turquette <mturquette@...libre.com>, linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>, Alim Akhtar <alim.akhtar@...sung.com>
Subject: Re: [GIT PULL fixes PATCH] clk: samsung: Revert "clk: Use device_get_match_data()"

Quoting Krzysztof Kozlowski (2024-04-30 11:46:56)
> From: Marek Szyprowski <m.szyprowski@...sung.com>
> 
> device_get_match_data() function should not be used on the device other
> than the one matched to the given driver, because it always returns the
> match_data of the matched driver. In case of exynos-clkout driver, the
> original code matches the OF IDs on the PARENT device, so replacing it
> with of_device_get_match_data() broke the driver.
> 
> This has been already pointed once in commit 2bc5febd05ab ("clk: samsung:
> Revert "clk: samsung: exynos-clkout: Use of_device_get_match_data()"").
> To avoid further confusion, add a comment about this special case, which
> requires direct of_match_device() call to pass custom IDs array.
> 
> This partially reverts commit 409c39ec92a35e3708f5b5798c78eae78512cd71.
> 
> Cc: <stable@...r.kernel.org>
> Fixes: 409c39ec92a3 ("clk: Use device_get_match_data()")
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Link: https://lore.kernel.org/r/20240425075628.838497-1-m.szyprowski@samsung.com
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Applied to clk-fixes