linux-kernel - Re: [PATCH v4 05/10] platform: Add test managed platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f4323025c9d25313ecf26327848fc62.sboyd@kernel.org>
Date: Tue, 30 Apr 2024 14:32:06 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, patches@...ts.linux.dev, kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org, devicetree@...r.kernel.org, Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Rafael J . Wysocki <rafael@...nel.org>, Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, Daniel Latypov <dlatypov@...gle.com>, Christian Marangi <ansuelsmth@...il.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Maxime Ripard <maxime@...no.tech>
Subject: Re: [PATCH v4 05/10] platform: Add test managed platform_device/driver APIs

Quoting Stephen Boyd (2024-04-24 11:11:21)
> Quoting Stephen Boyd (2024-04-22 16:23:58)
> > diff --git a/drivers/base/test/platform_kunit.c b/drivers/base/test/platform_kunit.c
[...]
> > +
> > +       /*
> > +        * Wait for the driver to probe (or at least flush out of the deferred
> > +        * workqueue)
> > +        */
> > +       wait_for_device_probe();
> 
> Should this be removed? I was thinking that this isn't a pure wrapper
> around platform_driver_register() because it has this wait call.  Maybe
> it's better to have some other kunit API that can wait for a specific
> device to probe and timeout if it doesn't happen in that amount of time.
> That API would use the bus notifiers and look for
> BUS_NOTIFY_BOUND_DRIVER. Or maybe that function could setup a completion
> that the test can wait on.

I have an implementation that does this that I'll send.