linux-kernel - Re: [PATCH v2] usb: dwc3: Wait unconditionally after issuing EndXfer command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 30 Apr 2024 22:59:58 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Prashanth K
	<quic_prashk@...cinc.com>
CC: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v2] usb: dwc3: Wait unconditionally after issuing EndXfer
 command

On Tue, Apr 30, 2024, Greg Kroah-Hartman wrote:
> On Thu, Apr 25, 2024 at 11:22:08PM +0000, Thinh Nguyen wrote:
> > On Thu, Apr 25, 2024, Prashanth K wrote:
> > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> > > index 4df2661f6675..666eae94524f 100644
> > > --- a/drivers/usb/dwc3/gadget.c
> > > +++ b/drivers/usb/dwc3/gadget.c
> > > @@ -1724,8 +1724,7 @@ static int __dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force, bool int
> > >  	dep->resource_index = 0;
> > >  
> > >  	if (!interrupt) {
> > > -		if (!DWC3_IP_IS(DWC3) || DWC3_VER_IS_PRIOR(DWC3, 310A))
> > > -			mdelay(1);
> > > +		mdelay(1);
> > >  		dep->flags &= ~DWC3_EP_TRANSFER_STARTED;
> > >  	} else if (!ret) {
> > >  		dep->flags |= DWC3_EP_END_TRANSFER_PENDING;
> > > -- 
> > > 2.25.1
> > > 
> > 
> > Acked-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
> 
> This patch breaks the build on my systems:
> 
>   CC [M]  drivers/usb/dwc3/gadget.o
> drivers/usb/dwc3/gadget.c: In function ‘__dwc3_stop_active_transfer’:
> drivers/usb/dwc3/gadget.c:1702:22: error: unused variable ‘dwc’ [-Werror=unused-variable]
>  1702 |         struct dwc3 *dwc = dep->dwc;
>       |                      ^~~
> cc1: all warnings being treated as errors
> 
> so I can't take it :(

Thanks Greg for reporting.

Hi Prashanth,

Can you resend v3 with the build fix. You can keep my Acked-by. Also,
please help test and catch these issues early to avoid turn-around time.

Thanks,
Thinh