linux-kernel - Re: [PATCH v2] ALSA: usb-audio: Add sampling rates support for Mbox3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cyq7nw19.wl-tiwai@suse.de>
Date: Tue, 30 Apr 2024 09:34:42 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Manuel Barrio Linares <mbarriolinares@...il.com>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Geraldo Nascimento <geraldogabriel@...il.com>,
	dengxiang <dengxiang@...china.com>,
	Jussi Laako <jussi@...arnerd.net>,
	Christos Skevis <xristos.thes@...il.com>,
	Alexander Tsoy <alexander@...y.me>,
	Jeremie Knuesel <knuesel@...il.com>,
	WhaleChang <whalechang@...gle.com>,
	Sean Young <sean@...s.org>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: usb-audio: Add sampling rates support for Mbox3

On Mon, 29 Apr 2024 21:35:00 +0200,
Manuel Barrio Linares wrote:
> 
> +	set_rate = le32_to_cpu(buff4);
> +	if (new_rate != set_rate)

Those two lines cause sparse warnings, unfortunately.
You can't assign int to __le32 type directly, and you can't compare
between those types directly, either.

That said, it should be rather like

	if (new_rate != le32_to_cpu(buff4))
		dev_warn(...);


You can check the sparse warning by yourself by passing C=1 argument
to make, too.


thanks,

Takashi