linux-kernel - Re: [PATCH v4 04/10] PCI: qcom-ep: Drop 'Link is enabled' from the debug message for BME event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 30 Apr 2024 10:05:42 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Jingoo Han <jingoohan1@...il.com>,
	Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>, linux-pci@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	mhi@...ts.linux.dev, linux-tegra@...r.kernel.org,
	Bjorn Helgaas <helgaas@...nel.org>
Subject: Re: [PATCH v4 04/10] PCI: qcom-ep: Drop 'Link is enabled' from the
 debug message for BME event

On Tue, Apr 30, 2024 at 11:43:45AM +0530, Manivannan Sadhasivam wrote:
> Bus Master Enable (BME) event that is generated by the Qcom PCIe EP
> controller due to host setting the Bus Master Enable bit in the Command
> register doesn't have anything to do with the PCIe link.
> 
> Hence, drop the bogus statement.
> 
> Suggested-by: Bjorn Helgaas <helgaas@...nel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>  drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> index f6e925d434f6..dcac177b55fb 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> @@ -636,7 +636,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data)
>  		pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN;
>  		pci_epc_linkdown(pci->ep.epc);
>  	} else if (FIELD_GET(PARF_INT_ALL_BME, status)) {
> -		dev_dbg(dev, "Received Bus Master Enable event. Link is enabled!\n");
> +		dev_dbg(dev, "Received Bus Master Enable event\n");
>  		pcie_ep->link_status = QCOM_PCIE_EP_LINK_ENABLED;
>  		qcom_pcie_ep_icc_update(pcie_ep);
>  		pci_epc_bus_master_enable_notify(pci->ep.epc);
> 
> -- 
> 2.25.1
> 

Reviewed-by: Niklas Cassel <cassel@...nel.org>