linux-kernel - Re: [PATCH] kselftest: Add a ksft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG4es9VDsiWdhAHuBkS-+GkQeW+m5DeJC0mdDLEmOh1PDfQBdw@mail.gmail.com>
Date: Mon, 29 Apr 2024 18:05:14 -0700
From: Edward Liaw <edliaw@...gle.com>
To: stable@...r.kernel.org, Shuah Khan <shuah@...nel.org>
Cc: kernel-team@...roid.com, Mark Brown <broonie@...nel.org>, 
	Kees Cook <keescook@...omium.org>, Shuah Khan <skhan@...uxfoundation.org>, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest: Add a ksft_perror() helper

Sorry, will resend this; I forgot to prefix that it was intended for
the 6.6.y branch.

On Mon, Apr 29, 2024 at 5:49 PM Edward Liaw <edliaw@...gle.com> wrote:
>
> From: Mark Brown <broonie@...nel.org>
>
> [ Upstream commit 907f33028871fa7c9a3db1efd467b78ef82cce20 ]
>
> The standard library perror() function provides a convenient way to print
> an error message based on the current errno but this doesn't play nicely
> with KTAP output. Provide a helper which does an equivalent thing in a KTAP
> compatible format.
>
> nolibc doesn't have a strerror() and adding the table of strings required
> doesn't seem like a good fit for what it's trying to do so when we're using
> that only print the errno.
>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> Reviewed-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
> Stable-dep-of: 071af0c9e582 ("selftests: timers: Convert posix_timers test to generate KTAP output")
> Signed-off-by: Edward Liaw <edliaw@...gle.com>
> ---
>  tools/testing/selftests/kselftest.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index e8eecbc83a60..ad7b97e16f37 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -48,6 +48,7 @@
>  #include <stdlib.h>
>  #include <unistd.h>
>  #include <stdarg.h>
> +#include <string.h>
>  #include <stdio.h>
>  #include <sys/utsname.h>
>  #endif
> @@ -156,6 +157,19 @@ static inline void ksft_print_msg(const char *msg, ..)
>         va_end(args);
>  }
>
> +static inline void ksft_perror(const char *msg)
> +{
> +#ifndef NOLIBC
> +       ksft_print_msg("%s: %s (%d)\n", msg, strerror(errno), errno);
> +#else
> +       /*
> +        * nolibc doesn't provide strerror() and it seems
> +        * inappropriate to add one, just print the errno.
> +        */
> +       ksft_print_msg("%s: %d)\n", msg, errno);
> +#endif
> +}
> +
>  static inline void ksft_test_result_pass(const char *msg, ...)
>  {
>         int saved_errno = errno;
> --
> 2.44.0.769.g3c40516874-goog
>