linux-kernel - [PATCH] regulator: rt5739: Enable REGCACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240430010140.2027-1-jszhang@kernel.org>
Date: Tue, 30 Apr 2024 09:01:40 +0800
From: Jisheng Zhang <jszhang@...nel.org>
To: Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: [PATCH] regulator: rt5739: Enable REGCACHE_FLAT

Enable regmap cache to reduce i2c transactions and corresponding
interrupts if regulator is accessed frequently. Since the register map
is small, we use a FLAT regmap cache.

Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
---
 drivers/regulator/rt5739.c | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/drivers/regulator/rt5739.c b/drivers/regulator/rt5739.c
index 91412c905ce6..47172b11301c 100644
--- a/drivers/regulator/rt5739.c
+++ b/drivers/regulator/rt5739.c
@@ -24,8 +24,11 @@
 #define RT5739_REG_NSEL1	0x01
 #define RT5739_REG_CNTL1	0x02
 #define RT5739_REG_ID1		0x03
+#define RT5739_REG_ID2		0x04
+#define RT5739_REG_MON		0x05
 #define RT5739_REG_CNTL2	0x06
 #define RT5739_REG_CNTL4	0x08
+#define RT5739_MAX_REGS		(RT5739_REG_CNTL4 + 1)
 
 #define RT5739_VSEL_MASK	GENMASK(7, 0)
 #define RT5739_MODEVSEL1_MASK	BIT(1)
@@ -236,11 +239,46 @@ static void rt5739_init_regulator_desc(struct regulator_desc *desc,
 	}
 }
 
+static bool rt5739_writeable_reg(struct device *dev, unsigned int reg)
+{
+	switch (reg) {
+	case RT5739_REG_NSEL0 ... RT5739_REG_CNTL1:
+	case RT5739_REG_CNTL2:
+	case RT5739_REG_CNTL4:
+		return true;
+	default:
+		return false;
+	}
+}
+
+static bool rt5739_readable_reg(struct device *dev, unsigned int reg)
+{
+	switch (reg) {
+	case RT5739_REG_NSEL0 ... RT5739_REG_CNTL2:
+	case RT5739_REG_CNTL4:
+		return true;
+	default:
+		return false;
+	}
+}
+
+static bool rt5739_volatile_reg(struct device *dev, unsigned int reg)
+{
+	if (reg == RT5739_REG_MON)
+		return true;
+	return false;
+}
+
 static const struct regmap_config rt5739_regmap_config = {
 	.name = "rt5739",
 	.reg_bits = 8,
 	.val_bits = 8,
 	.max_register = RT5739_REG_CNTL4,
+	.num_reg_defaults_raw = RT5739_MAX_REGS,
+	.cache_type = REGCACHE_FLAT,
+	.writeable_reg = rt5739_writeable_reg,
+	.readable_reg = rt5739_readable_reg,
+	.volatile_reg = rt5739_volatile_reg,
 };
 
 static int rt5739_probe(struct i2c_client *i2c)
-- 
2.43.0