linux-kernel - Re: [PATCH -next] proc: Remove unnecessary interrupts.c include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6844a9d8-f1a7-738e-105c-e9c44f5c11f4@huawei.com>
Date: Tue, 30 Apr 2024 09:23:51 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: Andrew Morton <akpm@...ux-foundation.org>
CC: <mcgrof@...nel.org>, <j.granados@...sung.com>, <brauner@...nel.org>,
	<david@...hat.com>, <willy@...radead.org>, <oleg@...hat.com>,
	<linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH -next] proc: Remove unnecessary interrupts.c include



On 2024/4/30 0:35, Andrew Morton wrote:
> On Sun, 28 Apr 2024 17:48:47 +0800 Jinjie Ruan <ruanjinjie@...wei.com> wrote:
> 
>> The irqnr.h is included in interrupts.h and the fs.h is included in
>> proc_fs.h, they are unnecessary included in interrupts.c, so remove it.
>>
>> ...
>>
>> --- a/fs/proc/interrupts.c
>> +++ b/fs/proc/interrupts.c
>> @@ -1,8 +1,6 @@
>>  // SPDX-License-Identifier: GPL-2.0
>> -#include <linux/fs.h>
>>  #include <linux/init.h>
>>  #include <linux/interrupt.h>
>> -#include <linux/irqnr.h>
>>  #include <linux/proc_fs.h>
>>  #include <linux/seq_file.h>
> 
> Within limits, we prefer that .c files directly include the headers
> which they use.  If interrupts.c uses nothing from these headers then
> OK.  If, however, interrupts.c does use things which are defined in
> these headers then the inclusion of those headers is desired.

Thank you, sorry I'm just learning the rules now.