linux-kernel - Re: [PATCH 1/2] cpufreq: amd-pstate: fix code format problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h73Pacu-70ps22WBNvXG+SCSBoa-j0wERA2tfqf3qs6g@mail.gmail.com>
Date: Tue, 30 Apr 2024 12:23:45 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Perry Yuan <perry.yuan@....com>
Cc: rafael.j.wysocki@...el.com, Mario.Limonciello@....com, 
	viresh.kumar@...aro.org, gautham.shenoy@....com, Borislav.Petkov@....com, 
	Ray.Huang@....com, Alexander.Deucher@....com, Xinmei.Huang@....com, 
	oleksandr@...alenko.name, Xiaojian.Du@....com, Li.Meng@....com, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] cpufreq: amd-pstate: fix code format problems

On Tue, Apr 30, 2024 at 9:49 AM Perry Yuan <perry.yuan@....com> wrote:
>
> get some code format problems fixed in the amd-pstate driver.
>
> Changes Made:
>
> - Fixed incorrect comment format in the functions.
>
> - Removed unnecessary blank line.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404271148.HK9yHBlB-lkp@intel.com/
> Signed-off-by: Perry Yuan <perry.yuan@....com>
> Reviewed-by: Mario Limonciello <mario.limonciello@....com>

As this is a resend of a patch that has been posted already, it would
be good to indicate that somehow.  For example, send the whole series
as v2 and say in the notes below the changelog that a Reviewed-by tag
has been added between v1 and v2.  And for the second patch, say that
it is new in v2.

That said, this particular case is simple enough for me to see what's
going on right away.

Both patches in the series applied, thanks!

> ---
>  drivers/cpufreq/amd-pstate.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 83a29b257794..85656342a101 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -792,7 +792,7 @@ static void amd_pstate_update_limits(unsigned int cpu)
>         mutex_unlock(&amd_pstate_driver_lock);
>  }
>
> -/**
> +/*
>   * Get pstate transition delay time from ACPI tables that firmware set
>   * instead of using hardcode value directly.
>   */
> @@ -807,7 +807,7 @@ static u32 amd_pstate_get_transition_delay_us(unsigned int cpu)
>         return transition_delay_ns / NSEC_PER_USEC;
>  }
>
> -/**
> +/*
>   * Get pstate transition latency value from ACPI tables that firmware
>   * set instead of using hardcode value directly.
>   */
> @@ -822,7 +822,7 @@ static u32 amd_pstate_get_transition_latency(unsigned int cpu)
>         return transition_latency;
>  }
>
> -/**
> +/*
>   * amd_pstate_init_freq: Initialize the max_freq, min_freq,
>   *                       nominal_freq and lowest_nonlinear_freq for
>   *                       the @cpudata object.
> @@ -843,7 +843,6 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata)
>         u32 boost_ratio, lowest_nonlinear_ratio;
>         struct cppc_perf_caps cppc_perf;
>
> -
>         ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf);
>         if (ret)
>                 return ret;
> --
> 2.34.1
>
>