linux-kernel - Re: [PATCH] dt-bindings: clock: fixed: Define a preferred node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Apr 2024 17:11:32 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Michael Turquette <mturquette@...libre.com>, Rob Herring (Arm) <robh@...nel.org>
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: fixed: Define a preferred node name

Quoting Rob Herring (Arm) (2024-04-25 11:38:09)
> diff --git a/Documentation/devicetree/bindings/clock/fixed-clock.yaml b/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> index b0a4fb8256e2..d287bd092054 100644
> --- a/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> @@ -11,6 +11,13 @@ maintainers:
>    - Stephen Boyd <sboyd@...nel.org>
>  
>  properties:
> +  $nodename:
> +    anyOf:
> +      - description: Preferred name is 'clock-<freq>'

Is the preferred value of <freq> the clock-frequency property? Should
say that explicitly somehow so that it's clear.

> +        pattern: "^clock-([0-9]+|[a-z0-9-]+)$"
> +      - description: Any name allowed
> +        deprecated: true
> +
>    compatible:
>      const: fixed-clock
>  
> diff --git a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> index 8f71ab300470..962a1fe85416 100644
> --- a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> @@ -11,6 +11,14 @@ maintainers:
>    - Stephen Boyd <sboyd@...nel.org>
>  
>  properties:
> +  $nodename:
> +    anyOf:
> +      - description:
> +          Preferred name is 'clock-<freq>' if the input frequency is fixed

Similar question here. Is <freq> supposed to be the output clock frequency?

> +        pattern: "^clock-([0-9]+|[0-9a-z-]+)$"
> +      - description: Any name allowed
> +        deprecated: true

I hope that deprecating this doesn't cause folks to try to clean things
up and then break code that's depending on the node name to be the name
of the clk. We don't want that string name to be important but it is
sometimes.