linux-kernel - Re: [PATCH v6 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b69a2bbfa713374e0bbd9f306ee554ee99f70d3.camel@codeconstruct.com.au>
Date: Tue, 30 Apr 2024 10:58:57 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Kelly Hung <ppighouse@...il.com>, robh+dt@...nel.org
Cc: krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, joel@....id.au, 
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org, 
 openbmc@...ts.ozlabs.org, kelly_hung@...s.com, Allenyy_Hsu@...s.com,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Rob Herring
 <robh@...nel.org>, Zev Weiss <zweiss@...inix.com>, Conor Dooley
 <conor.dooley@...rochip.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board

On Tue, 2024-03-26 at 18:35 +0800, Kelly Hung wrote:
> Document the new compatibles used on ASUS X4TF.
> 
> Signed-off-by: Kelly Hung <Kelly_Hung@...s.com>

In addition to the concerns of others, your author email is not the
same as your SoB email. checkpatch warns:

```
WARNING: From:/Signed-off-by: email address mismatch: 'From: Kelly Hung
<ppighouse@...il.com>' != 'Signed-off-by: Kelly Hung
<Kelly_Hung@...s.com>'

total: 0 errors, 1 warnings, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-
inplace.

Commit bb035db4c70a ("dt-bindings: arm: aspeed: add ASUS X4TF board")
has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
```

Please fix this issue for both patches in the series and resend.

Thanks,

Andrew