linux-kernel - Re: [PATCH V3 2/2] scsi: qla2xxx: Optimisation of exception handling in qla24xx_els_dcmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <230af978-c834-423b-8d42-78c164be40b9@web.de>
Date: Tue, 30 Apr 2024 13:21:19 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Yongzhi Liu <hyperlyzcs@...il.com>,
 GR-QLogic-Storage-Upstream@...vell.com, linux-scsi@...r.kernel.org,
 kernel-janitors@...r.kernel.org,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Nilesh Javali <njavali@...vell.com>, Saurav Kashyap <skashyap@...vell.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Himanshu Madhani <himanshu.madhani@...cle.com>, huntazhang@...cent.com,
 jitxie@...cent.com
Subject: Re: [PATCH V3 2/2] scsi: qla2xxx: Optimisation of exception handling
 in qla24xx_els_dcmd_iocb

Would you like to use the summary phrase “Use common error handling code in qla24xx_els_dcmd_iocb()”?

> To avoid duplicate error handling code a bit more, use more common goto
> chain in qla24xx_els_dcmd_iocb.

How do you think about the following wording?

   Add a jump target so that a bit of exception handling can be better reused
   at the end of this function implementation.

Can the tag “Suggested-by” be helpful for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n586

Regards,
Markus