| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <e694ba58197687dce68d568dfcb078ff3a6c6fed.camel@codeconstruct.com.au>
Date: Tue, 30 Apr 2024 11:08:17 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Peter Yin <peteryin.openbmc@...il.com>
Cc: patrick@...cx.xyz, Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter
Roeck <linux@...ck-us.net>, Joel Stanley <joel@....id.au>,
linux-watchdog@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 1/1] drivers: watchdog: revise watchdog bootstatus
On Mon, 2024-04-29 at 22:54 +0800, Peter Yin wrote:
> Hi Andrew,
> I am not sure how to add the Fixes tag, Is it like this?
>
> Fixes: 6a6c7b006e5c (watchdog: aspeed: Add support for
> aspeed,reset-mask DT property).
Approximately, yes, but it must not be wrapped.
Some more info is provided in the submitting-patches documentation:
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> Signed-off-by: Peter Yin <peteryin.openbmc@...il.com>
>
> Is it the correct commit ID or should I base on which commit ID?
>
The correct commit ID to use is the one that introduces the problem.
Using `git blame drivers/watchdog/aspeed_wdt.c` it appears you're
changing the behaviour that was introduced in 49d4d277ca54 ("aspeed:
watchdog: Set bootstatus during probe"):
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=49d4d277ca54e04170d39484c8758a0ea9bca37d
Andrew
Powered by blists - more mailing lists