linux-kernel - Re: [PATCH v7 05/16] module: make module_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5248d22-672d-4acc-9b12-86815d6e22dc@linaro.org>
Date: Tue, 30 Apr 2024 14:41:22 +0200
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: Mike Rapoport <rppt@...nel.org>, linux-kernel@...r.kernel.org
Cc: Alexandre Ghiti <alexghiti@...osinc.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Björn Töpel
 <bjorn@...nel.org>, Catalin Marinas <catalin.marinas@....com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 "David S. Miller" <davem@...emloft.net>, Dinh Nguyen <dinguyen@...nel.org>,
 Donald Dutile <ddutile@...hat.com>, Eric Chanudet <echanude@...hat.com>,
 Heiko Carstens <hca@...ux.ibm.com>, Helge Deller <deller@....de>,
 Huacai Chen <chenhuacai@...nel.org>,
 Kent Overstreet <kent.overstreet@...ux.dev>,
 Luis Chamberlain <mcgrof@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Masami Hiramatsu <mhiramat@...nel.org>, Michael Ellerman
 <mpe@...erman.id.au>, Nadav Amit <nadav.amit@...il.com>,
 Palmer Dabbelt <palmer@...belt.com>, Peter Zijlstra <peterz@...radead.org>,
 Rick Edgecombe <rick.p.edgecombe@...el.com>,
 Russell King <linux@...linux.org.uk>, Sam Ravnborg <sam@...nborg.org>,
 Song Liu <song@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Thomas Gleixner <tglx@...utronix.de>, Will Deacon <will@...nel.org>,
 bpf@...r.kernel.org, linux-arch@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
 linux-mm@...ck.org, linux-modules@...r.kernel.org,
 linux-parisc@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, loongarch@...ts.linux.dev,
 netdev@...r.kernel.org, sparclinux@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v7 05/16] module: make module_memory_{alloc,free} more
 self-contained

On 29/4/24 14:16, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <rppt@...nel.org>
> 
> Move the logic related to the memory allocation and freeing into
> module_memory_alloc() and module_memory_free().
> 
> Signed-off-by: Mike Rapoport (IBM) <rppt@...nel.org>
> ---
>   kernel/module/main.c | 64 +++++++++++++++++++++++++++-----------------
>   1 file changed, 39 insertions(+), 25 deletions(-)

Nice code simplification.

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>