linux-kernel - Re: [PATCH 11/15] i2c: jz4780: use 'time_left' variable with wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85cfd4f4-ce6f-4c38-8c51-25c72e3ffa9f@linaro.org>
Date: Tue, 30 Apr 2024 14:43:40 +0200
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>, linux-i2c@...r.kernel.org
Cc: Paul Cercueil <paul@...pouillou.net>, Andi Shyti <andi.shyti@...nel.org>,
 linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/15] i2c: jz4780: use 'time_left' variable with
 wait_for_completion_timeout()

On 27/4/24 22:36, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_completion_timeout() causing patterns like:
> 
> 	timeout = wait_for_completion_timeout(...)
> 	if (!timeout) return -ETIMEDOUT;
> 
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> self explaining.
> 
> Fix to the proper variable type 'unsigned long' while here.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>   drivers/i2c/busses/i2c-jz4780.c | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>