linux-kernel - Re: [PATCH] RDMA/core: Remove NULL check before dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240430132131.GG100414@unreal>
Date: Tue, 30 Apr 2024 16:21:31 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Jules Irenge <jbi.octave@...il.com>
Cc: jgg@...pe.ca, wenglianfa@...wei.com, gustavoars@...nel.org,
	lishifeng@...gfor.com.cn, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/core: Remove NULL check before dev_{put, hold}

On Sun, Apr 28, 2024 at 02:34:56PM +0100, Jules Irenge wrote:
> Coccinelle reports a warning
> 
> WARNING: NULL check before dev_{put, hold} functions is not needed

Please do it for whole drivers/infiniband/core in one patch, please.

> 
> The reason is the call netdev_{put, hold} of dev_{put,hold} will check NULL
> There is no need to check before using dev_{put, hold}
> 
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>
> ---
>  drivers/infiniband/core/device.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 07cb6c5ffda0..84be4bb9b625 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -2235,8 +2235,7 @@ struct net_device *ib_device_get_netdev(struct ib_device *ib_dev,
>  		spin_lock(&pdata->netdev_lock);
>  		res = rcu_dereference_protected(
>  			pdata->netdev, lockdep_is_held(&pdata->netdev_lock));
> -		if (res)
> -			dev_hold(res);
> +		dev_hold(res);
>  		spin_unlock(&pdata->netdev_lock);
>  	}
>  
> -- 
> 2.43.2
>