lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 30 Apr 2024 16:16:09 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: linux-s390@...r.kernel.org, open list <linux-kernel@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>, lkft-triage@...ts.linaro.org,
        Linux Regressions <regressions@...ts.linux.dev>, imx@...ts.linux.dev,
        Abel Vesa <abelvesa@...nel.org>, Abel Vesa <abel.vesa@...aro.org>,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: Shengjiu Wang <shengjiu.wang@....com>, Shawn Guo <shawnguo@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Arnd Bergmann <arnd@...db.de>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        Anders Roxell <anders.roxell@...aro.org>, peng.fan@....com
Subject: [PATCH] clk: imx: imx8mp: Add missing CONFIG_PM ifdefs

Add missing CONFIG_PM ifdefs to fix this allmodconfig compile error:

drivers/clk/imx/clk-imx8mp-audiomix.c:356:12: error:
'clk_imx8mp_audiomix_runtime_suspend' defined but not used
[-Werror=unused-function]
  356 | static int clk_imx8mp_audiomix_runtime_suspend(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
Closes: https://lore.kernel.org/r/CA+G9fYuP7S+a89Ep5g5_Ad69EMwRkJ8nM+MMTzbEcP+6H2oMXQ@mail.gmail.com
Fixes: 1496dd413b2e ("clk: imx: imx8mp: Add pm_runtime support for power saving")
Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
---
 drivers/clk/imx/clk-imx8mp-audiomix.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c
index 574a032309c1..6549e55e94c9 100644
--- a/drivers/clk/imx/clk-imx8mp-audiomix.c
+++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
@@ -217,6 +217,8 @@ struct clk_imx8mp_audiomix_priv {
 	struct clk_hw_onecell_data clk_data;
 };
 
+#ifdef CONFIG_PM
+
 static void clk_imx8mp_audiomix_save_restore(struct device *dev, bool save)
 {
 	struct clk_imx8mp_audiomix_priv *priv = dev_get_drvdata(dev);
@@ -232,6 +234,8 @@ static void clk_imx8mp_audiomix_save_restore(struct device *dev, bool save)
 	}
 }
 
+#endif /* CONFIG_PM */
+
 static int clk_imx8mp_audiomix_probe(struct platform_device *pdev)
 {
 	struct clk_imx8mp_audiomix_priv *priv;
@@ -353,6 +357,8 @@ static int clk_imx8mp_audiomix_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_PM
+
 static int clk_imx8mp_audiomix_runtime_suspend(struct device *dev)
 {
 	clk_imx8mp_audiomix_save_restore(dev, true);
@@ -367,6 +373,8 @@ static int clk_imx8mp_audiomix_runtime_resume(struct device *dev)
 	return 0;
 }
 
+#endif /* CONFIG_PM */
+
 static const struct dev_pm_ops clk_imx8mp_audiomix_pm_ops = {
 	SET_RUNTIME_PM_OPS(clk_imx8mp_audiomix_runtime_suspend,
 			   clk_imx8mp_audiomix_runtime_resume, NULL)
-- 
2.40.1


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ