linux-kernel - Re: [PATCH v4 8/8] memcg: use proper type for mod_memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 1 May 2024 16:23:52 -0700
From: Roman Gushchin <roman.gushchin@...ux.dev>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...nel.org>,
	Muchun Song <muchun.song@...ux.dev>,
	Yosry Ahmed <yosryahmed@...gle.com>,
	"T . J . Mercier" <tjmercier@...gle.com>, kernel-team@...a.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 8/8] memcg: use proper type for mod_memcg_state

On Wed, May 01, 2024 at 10:26:17AM -0700, Shakeel Butt wrote:
> The memcg stats update functions can take arbitrary integer but the
> only input which make sense is enum memcg_stat_item and we don't
> want these functions to be called with arbitrary integer, so replace
> the parameter type with enum memcg_stat_item and compiler will be able
> to warn if memcg stat update functions are called with incorrect index
> value.
> 
> Signed-off-by: Shakeel Butt <shakeel.butt@...ux.dev>
> Reviewed-by: T.J. Mercier <tjmercier@...gle.com>

Reviewed-by: Roman Gushchin <roman.gushchin@...ux.dev>

Thanks!