linux-kernel - RE: [PATCH V2] firmware: arm_scmi: power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB9417117051682D9BC5B195D988192@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date: Wed, 1 May 2024 23:52:52 +0000
From: Peng Fan <peng.fan@....com>
To: Cristian Marussi <cristian.marussi@....com>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: "sudeep.holla@....com" <sudeep.holla@....com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2] firmware: arm_scmi: power_control: support suspend
 command

> Subject: Re: [PATCH V2] firmware: arm_scmi: power_control: support
> suspend command
> 
> On Sun, Apr 28, 2024 at 03:51:05PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > Support System suspend notification. Using a work struct to call
> > pm_suspend. There is no way to pass suspend level to pm_suspend, so
> > use MEM as of now.
> >
> > - The choice of S2R(MEM) by default. The userspace can configure whatever
> >   default behaviour expected as S2R, if issuing suspend from userspace.
> >
> > - The userspace needs to keep the wakeup source enabled, otherwise the
> >   system may never resume back.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> 
> Have you tried triggering a suspend with this on your setup ?

Yes, this feature is already in NXP internal git tree and tested.

> 
> Anyway, LGTM.
> Reviewed-by: Cristian Marussi <cristian.marussi@....com>
> 

Thanks,
Peng.
> Thanks,
> Cristian