linux-kernel - Re: [PATCH] media: dvb_ca_en50221: Fix a bug for detecting CI MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANXPkT5YMTLJTmZLv3yB8Db4vDB_iDmyqNh9aoPGyBdzLKUA2w@mail.gmail.com>
Date: Wed, 1 May 2024 16:54:07 +0900
From: YongSu Yoo <yongsuyoo0215@...il.com>
To: mchehab@...nel.org, yongsuyoo0215@...il.com, v4bel@...ori.io, 
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dvb_ca_en50221: Fix a bug for detecting CI MODULE

Dear All

Can you review this patch ?
Can you share how this is going ?

2024년 4월 11일 (목) 오후 9:03, YongSu Yoo <yongsuyoo0215@...il.com>님이 작성:
>
> Dear All
>
> Can you review this patch ?
> Can you share how this modification is going ?
>
> 2024년 3월 8일 (금) 오후 9:10, <yongsuyoo0215@...il.com>님이 작성:
> >
> > From: Yongsu yoo <yongsuyoo0215@...il.com>
> >
> > Signed-off-by:Yongsu Yoo <yongsuyoo0215@...il.com>
> >
> > In source/drivers/media/dvb-core/dvb_ca_en50221.c, if the CA_RESET
> > ioctl is called, the dvb_ca_en50221_slot_shutdown will also be called.
> > Inside of the dvb_ca_en50221_slot_shutdown,
> > the ca->slot_info[slot].slot_state will become DVB_CA_SLOTSTATE_NONE.
> > In the most of cases, the ca->slot_info[slot].slot_state will quickly
> > becomes restored to other states by the subsequent operations of the
> > thread dvb_ca_en50221_thread_state_machine.
> > But in some rare cases, when the CA_GET_SLOT_INFO ioctl is immediately
> > called after the CA_RESET ioctl is called, the
> > the ca->slot_info[slot].slot_state can still remains at
> > DVB_CA_SLOTSTATE_NONE, and this causes CA_GET_SLOT_INFO ioctl not to
> > return CA_CI_MODULE_PRESENT as info->flags even if CA_CI_MODULE is
> > really connected on TV. This means that the CA_GET_SLOT_INFO ioctl
> > does not return right informtion. This is a Bug. We fix this bug.
> > ---
> >  drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c b/drivers/media/dvb-core/dvb_ca_en50221.c
> > index baf64540dc00..8d37c3c13227 100644
> > --- a/drivers/media/dvb-core/dvb_ca_en50221.c
> > +++ b/drivers/media/dvb-core/dvb_ca_en50221.c
> > @@ -1403,6 +1403,10 @@ static int dvb_ca_en50221_io_do_ioctl(struct file *file,
> >                     (sl->slot_state != DVB_CA_SLOTSTATE_INVALID)) {
> >                         info->flags = CA_CI_MODULE_PRESENT;
> >                 }
> > +               if ((sl->slot_state == DVB_CA_SLOTSTATE_NONE) &&
> > +                   (sl->camchange_type == DVB_CA_EN50221_CAMCHANGE_INSERTED)) {
> > +                       info->flags = CA_CI_MODULE_PRESENT;
> > +               }
> >                 if (sl->slot_state == DVB_CA_SLOTSTATE_RUNNING)
> >                         info->flags |= CA_CI_MODULE_READY;
> >                 break;
> > --
> > 2.17.1
> >