linux-kernel - Re: [PATCH v6] Bluetooth: compute LE flow credits based on recvbuf space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 1 May 2024 17:22:23 +0800
From: kernel test robot <lkp@...el.com>
To: Sebastian Urban <surban@...ban.net>
Cc: oe-kbuild-all@...ts.linux.dev, Sebastian Urban <surban@...ban.net>,
	Marcel Holtmann <marcel@...tmann.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	Luiz Augusto von Dentz <luiz.dentz@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] Bluetooth: compute LE flow credits based on recvbuf
 space

Hi Sebastian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on linus/master v6.9-rc6 next-20240430]
[cannot apply to bluetooth/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sebastian-Urban/Bluetooth-compute-LE-flow-credits-based-on-recvbuf-space/20240501-075548
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
patch link:    https://lore.kernel.org/r/20240430235122.37716-1-surban%40surban.net
patch subject: [PATCH v6] Bluetooth: compute LE flow credits based on recvbuf space
config: openrisc-allmodconfig (https://download.01.org/0day-ci/archive/20240501/202405011748.NWhismdZ-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240501/202405011748.NWhismdZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405011748.NWhismdZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/asm-generic/bug.h:22,
                    from arch/openrisc/include/asm/bug.h:5,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:13,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/openrisc/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:79,
                    from include/linux/spinlock.h:56,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from include/linux/umh.h:4,
                    from include/linux/kmod.h:9,
                    from include/linux/module.h:17,
                    from net/bluetooth/l2cap_core.c:31:
   net/bluetooth/l2cap_core.c: In function 'l2cap_chan_rx_avail':
>> net/bluetooth/l2cap_core.c:6570:16: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'ssize_t' {aka 'int'} [-Wformat=]
    6570 |         BT_DBG("chan %p has %ld bytes avail for rx", chan, rx_avail);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/printk.h:347:21: note: in definition of macro 'pr_fmt'
     347 | #define pr_fmt(fmt) fmt
         |                     ^~~
   include/linux/dynamic_debug.h:248:9: note: in expansion of macro '__dynamic_func_call_cls'
     248 |         __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:250:9: note: in expansion of macro '_dynamic_func_call_cls'
     250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:269:9: note: in expansion of macro '_dynamic_func_call'
     269 |         _dynamic_func_call(fmt, __dynamic_pr_debug,             \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/printk.h:581:9: note: in expansion of macro 'dynamic_pr_debug'
     581 |         dynamic_pr_debug(fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~
   include/net/bluetooth/bluetooth.h:271:33: note: in expansion of macro 'pr_debug'
     271 | #define BT_DBG(fmt, ...)        pr_debug(fmt "\n", ##__VA_ARGS__)
         |                                 ^~~~~~~~
   net/bluetooth/l2cap_core.c:6570:9: note: in expansion of macro 'BT_DBG'
    6570 |         BT_DBG("chan %p has %ld bytes avail for rx", chan, rx_avail);
         |         ^~~~~~
   net/bluetooth/l2cap_core.c:6570:31: note: format string is defined here
    6570 |         BT_DBG("chan %p has %ld bytes avail for rx", chan, rx_avail);
         |                             ~~^
         |                               |
         |                               long int
         |                             %d


vim +6570 net/bluetooth/l2cap_core.c

  6564	
  6565	void l2cap_chan_rx_avail(struct l2cap_chan *chan, ssize_t rx_avail)
  6566	{
  6567		if (chan->rx_avail == rx_avail)
  6568			return;
  6569	
> 6570		BT_DBG("chan %p has %ld bytes avail for rx", chan, rx_avail);
  6571	
  6572		chan->rx_avail = rx_avail;
  6573	
  6574		if (chan->state == BT_CONNECTED)
  6575			l2cap_chan_le_send_credits(chan);
  6576	}
  6577	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki